WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 61018
EFL builder needs to pass "-i" to to create_hash_table script
https://bugs.webkit.org/show_bug.cgi?id=61018
Summary
EFL builder needs to pass "-i" to to create_hash_table script
Geoffrey Garen
Reported
2011-05-17 20:25:38 PDT
Not doing so means the generated .lut.h files don't #include Lookup.h, so they don't build. The EFL builder is currently broken because of this, but I'm not familiar enough with the system to fix it. You can look at JavaScriptCore/GNUMakefile.am, JavaScriptCore/DerivedSources.make, or JavaScriptCore/DerivedSources.pro for an example.
Attachments
Add attachment
proposed patch, testcase, etc.
Geoffrey Garen
Comment 1
2011-05-17 20:27:46 PDT
Assigning to
gyuyoung.kim@samsung.com
and CC'ing
leandro@profusion.mobi
because they're listed as the builder owners. Unfortunately, I've never worked with them on any WebKit code, so I'm not sure what the best way to get in touch with them is.
Gyuyoung Kim
Comment 2
2011-05-17 22:13:44 PDT
Ok, I look into this problem.
Gyuyoung Kim
Comment 3
2011-05-18 00:55:19 PDT
In order to include Lookup.h, "-i" argument should be passed to create-hash-table. So, I add the "-i" option when cmake invokes the create_hash_table.
http://trac.webkit.org/changeset/86740
Geoffrey Garen
Comment 4
2011-05-18 13:14:05 PDT
Thanks!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug