Bug 61018 - EFL builder needs to pass "-i" to to create_hash_table script
Summary: EFL builder needs to pass "-i" to to create_hash_table script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-17 20:25 PDT by Geoffrey Garen
Modified: 2011-05-18 13:14 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-05-17 20:25:38 PDT
Not doing so means the generated .lut.h files don't #include Lookup.h, so they don't build.

The EFL builder is currently broken because of this, but I'm not familiar enough with the system to fix it.

You can look at JavaScriptCore/GNUMakefile.am, JavaScriptCore/DerivedSources.make, or JavaScriptCore/DerivedSources.pro for an example.
Comment 1 Geoffrey Garen 2011-05-17 20:27:46 PDT
Assigning to gyuyoung.kim@samsung.com and CC'ing leandro@profusion.mobi because they're listed as the builder owners.

Unfortunately, I've never worked with them on any WebKit code, so I'm not sure what the best way to get in touch with them is.
Comment 2 Gyuyoung Kim 2011-05-17 22:13:44 PDT
Ok, I look into this problem.
Comment 3 Gyuyoung Kim 2011-05-18 00:55:19 PDT
In order to include Lookup.h, "-i" argument should be passed to create-hash-table. So, I add the "-i" option when cmake invokes the create_hash_table. 

http://trac.webkit.org/changeset/86740
Comment 4 Geoffrey Garen 2011-05-18 13:14:05 PDT
Thanks!