Bug 60880 - WebSocket: WebSocketHandshake prints a carriage return to console
Summary: WebSocket: WebSocketHandshake prints a carriage return to console
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yuta Kitamura
URL:
Keywords:
Depends on:
Blocks: 60878
  Show dependency tree / graph
 
Reported: 2011-05-16 04:01 PDT by Yuta Kitamura
Modified: 2011-05-17 01:10 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.99 KB, patch)
2011-05-16 04:25 PDT, Yuta Kitamura 		tkent: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-05-16 04:01:18 PDT 
LayoutTest/http/tests/websocket/tests/handshake-error-expected.txt contains a carriage return in the first line. This caused svn-apply to fail  (see bug 60878).

This situation happened because of a bug in WebSocketHandshake; it prints a carriage return to console if status line is broken. Let's fix this.
Comment 1 Yuta Kitamura 2011-05-16 04:25:28 PDT 
Created attachment 93634 [details]
Patch
Comment 2 Yuta Kitamura 2011-05-16 04:33:14 PDT 
Comment on attachment 93634 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93634&action=review

> LayoutTests/http/tests/websocket/tests/handshake-error-expected.txt:1
> +CONSOLE MESSAGE: line 0: No response code found: ThisWillCauseHandshakeError

This hunk removes a carriage return at the end of line. EWS bots do not seem happy about this part, so I may have to commit this patch manually.
Comment 3 Kent Tamura 2011-05-16 18:11:05 PDT 
Comment on attachment 93634 [details]
Patch

ok
Comment 4 Yuta Kitamura 2011-05-17 01:10:11 PDT 
Manually committed r86659.