Bug 60878 - WebSocket: Add CLOSING state
Summary: WebSocket: Add CLOSING state
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yuta Kitamura
URL:
Keywords:
Depends on: 60880
Blocks: 35721
  Show dependency tree / graph
 
Reported: 2011-05-16 02:48 PDT by Yuta Kitamura
Modified: 2011-05-17 20:50 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.52 KB, patch)
2011-05-16 02:57 PDT, Yuta Kitamura 		no flags Details | Formatted Diff | Diff
Patch v2 (Add expected result for Qt) (12.65 KB, patch)
2011-05-16 04:41 PDT, Yuta Kitamura 		no flags Details | Formatted Diff | Diff
Ready to commit (12.69 KB, patch)
2011-05-17 01:23 PDT, Yuta Kitamura 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-05-16 02:48:59 PDT 
This is the first part of implementing WebSocket closing handshake (see bug 35721).

Add CLOSING state to WebSocket object. Due to a change of the value of WebSocket.CLOSE, we have to update expected results of tests that dump WebSocket.readyState.
Comment 1 Yuta Kitamura 2011-05-16 02:57:31 PDT 
Created attachment 93630 [details]
Patch
Comment 2 Kent Tamura 2011-05-16 03:01:00 PDT 
Comment on attachment 93630 [details]
Patch

r- because of EWS failures.
Comment 3 Yuta Kitamura 2011-05-16 03:36:10 PDT 
The EWS failure is not a fault of this patch.

LayoutTests/http/tests/websocket/tests/handshake-error-expected.txt contains a carriage return in the first line, which (seemingly) confuses svn-apply.

So, it sounds like another yak to shave...
Comment 4 Kent Tamura 2011-05-16 03:48:27 PDT 
(In reply to comment #3)
> The EWS failure is not a fault of this patch.
> 
> LayoutTests/http/tests/websocket/tests/handshake-error-expected.txt contains a carriage return in the first line, which (seemingly) confuses svn-apply.

I see.
Anyway, you need to update LayoutTests/qt/fast/dom/Window/window-properties-expected.txt too.
Comment 5 Yuta Kitamura 2011-05-16 04:41:00 PDT 
Created attachment 93635 [details]
Patch v2 (Add expected result for Qt)
Comment 6 Kent Tamura 2011-05-16 04:52:59 PDT 
Comment on attachment 93635 [details]
Patch v2 (Add expected result for Qt)

ok
Comment 7 Yuta Kitamura 2011-05-17 01:23:21 PDT 
Created attachment 93746 [details]
Ready to commit
Comment 8 Yuta Kitamura 2011-05-17 01:25:41 PDT 
(In reply to comment #7)
> Created an attachment (id=93746) [details]
> Ready to commit

I'd like to see the results of EWS bots before committing.
Comment 9 WebKit Commit Bot 2011-05-17 20:49:11 PDT 
The commit-queue encountered the following flaky tests while processing attachment 93746 [details]:

inspector/debugger/debugger-scripts.html bug 59921 (authors: pfeldman@chromium.org and podivilov@chromium.org)
http/tests/appcache/cyrillic-uri.html bug 61020 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2011-05-17 20:50:47 PDT 
Comment on attachment 93746 [details]
Ready to commit

Clearing flags on attachment: 93746

Committed r86732: <http://trac.webkit.org/changeset/86732>
Comment 11 WebKit Commit Bot 2011-05-17 20:50:53 PDT 
All reviewed patches have been landed.  Closing bug.