Bug 60760 – MediaElements fails to load the data in some cases.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Alexis Menard (darktears)]

When going to http://slides.html5rocks.com/#video-audio with the GTK port or Qt port using MediaPlayerGStreamer the video fails to load in some cases (basically depending on some timing regarding how the rendertree is constructed).

[Alexis Menard (darktears)]

Created attachment 93440 [details]
Patch

[Alexis Menard (darktears)]

(In reply to comment #1)
> Created an attachment (id=93440) [details]
> Patch

Looking for feedback for this patch :D. Should I also remove the similar call in RenderVideo, I believe it's not needed after that patch.

[Alexis Menard (darktears)]

Comment on attachment 93440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93440&action=review

> Source/WebCore/ChangeLog:14
> +        network context). At least the bug can be reproduce with Qt and GTK.

reproduced :D. Will fix.

[Simon Hausmann]

You can find an alternative solution that only touches the gstreamer back-end at
https://gitorious.org/+qtwebkit-webkit2-dev/webkit/qtwebkit-webkit2-dev/commit/7ae683e548a09cbec9f0e97e89a5e482f1fa9b74

[Alexis Menard (darktears)]

(In reply to comment #4)
> You can find an alternative solution that only touches the gstreamer back-end at
> https://gitorious.org/+qtwebkit-webkit2-dev/webkit/qtwebkit-webkit2-dev/commit/7ae683e548a09cbec9f0e97e89a5e482f1fa9b74

Yep, I thought about that too but I felt the problem could happen to anyone in fact.

[Philippe Normand]

Comment on attachment 93440 [details]
Patch

I think this patch makes sense indeed, would it be possible to have a layout test for it?

[Simon Hausmann]

(In reply to comment #5)
> (In reply to comment #4)
> > You can find an alternative solution that only touches the gstreamer back-end at
> > https://gitorious.org/+qtwebkit-webkit2-dev/webkit/qtwebkit-webkit2-dev/commit/7ae683e548a09cbec9f0e97e89a5e482f1fa9b74
> 
> Yep, I thought about that too but I felt the problem could happen to anyone in fact.

I agree that this can happen to others, too, but I think it's wrong of the others to use FrameView. IMHO it's cleaner to use the MediaPlayer* APIs in the MediaPlayer back-end implementation than WebCore::FrameView.

[Alexis Menard (darktears)]

*** Bug 60465 has been marked as a duplicate of this bug. ***

[Alexis Menard (darktears)]

Created attachment 93967 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 93967 [details]
Patch

Clearing flags on attachment: 93967

Committed r86790: <http://trac.webkit.org/changeset/86790>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ademar Reis]

Revision r86790 cherry-picked into qtwebkit-2.2 with commit e309ebe <http://gitorious.org/webkit/qtwebkit/commit/e309ebe>