Bug 60679 - Switch paintBoxDecorationWithSize to IntRect
Summary: Switch paintBoxDecorationWithSize to IntRect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60408 60578
  Show dependency treegraph
 
Reported: 2011-05-11 17:40 PDT by Levi Weintraub
Modified: 2011-05-12 19:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.85 KB, patch)
2011-05-12 15:08 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-05-11 17:40:28 PDT
Another four-ints-but-should-be-an-IntRect offender.
Comment 1 Levi Weintraub 2011-05-12 15:08:08 PDT
Created attachment 93351 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-12 15:10:25 PDT
Comment on attachment 93351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93351&action=review

> Source/WebCore/rendering/RenderBox.cpp:808
> +    if (paintInfo.shouldPaintWithinRoot(this))
> +        paintBoxDecorationsWithSize(paintInfo, IntRect(tx, ty, width(), height()));

I think I like the other style better.  But it doesn't really matter. :)
Comment 3 Levi Weintraub 2011-05-12 15:15:30 PDT
Comment on attachment 93351 [details]
Patch

Clearing flags on attachment: 93351

Committed r86385: <http://trac.webkit.org/changeset/86385>
Comment 4 Levi Weintraub 2011-05-12 15:15:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2011-05-12 17:24:29 PDT
const IntRect&!
Comment 6 Eric Seidel (no email) 2011-05-12 19:00:26 PDT
(In reply to comment #5)
> const IntRect&!

Oops.  Sorry. :(