WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
60408
[meta] Replace uses of tx/ty with IntSize
https://bugs.webkit.org/show_bug.cgi?id=60408
Summary
[meta] Replace uses of tx/ty with IntSize
Levi Weintraub
Reported
2011-05-06 15:02:43 PDT
tx/ty offsets used in painting are confusing and should be combined into either an IntSize or IntPoint -- likely IntSize. See the URL for a related discussion from WebKit-Dev.
Attachments
Add attachment
proposed patch, testcase, etc.
Levi Weintraub
Comment 1
2011-05-09 11:43:35 PDT
Considering how frequently tx/ty are used to construct points AND sizes, I now feel like this could warrant a new type to avoid the mess of calling this an point or size then repeatedly using it another way. Perhaps PaintOffset/IntOffset, which would allow easy conversion to points and sizes.
Levi Weintraub
Comment 2
2011-05-10 13:59:12 PDT
Updating with the name and making this a meta bug to track all the changes that'll help us make this switch.
Levi Weintraub
Comment 3
2011-06-06 19:17:02 PDT
We already have a metabug tracking this work, and we ended up using IntPoint instead of IntSize.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug