Bug 60408 - [meta] Replace uses of tx/ty with IntSize
Summary: [meta] Replace uses of tx/ty with IntSize
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: https://lists.webkit.org/pipermail/we...
Keywords:
Depends on: 60490 60578 60679
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2011-05-06 15:02 PDT by Levi Weintraub
Modified: 2011-06-06 19:17 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-05-06 15:02:43 PDT 
tx/ty offsets used in painting are confusing and should be combined into either an IntSize or IntPoint -- likely IntSize. See the URL for a related discussion from WebKit-Dev.
Comment 1 Levi Weintraub 2011-05-09 11:43:35 PDT 
Considering how frequently tx/ty are used to construct points AND sizes, I now feel like this could warrant a new type to avoid the mess of calling this an point or size then repeatedly using it another way. Perhaps PaintOffset/IntOffset, which would allow easy conversion to points and sizes.
Comment 2 Levi Weintraub 2011-05-10 13:59:12 PDT 
Updating with the name and making this a meta bug to track all the changes that'll help us make this switch.
Comment 3 Levi Weintraub 2011-06-06 19:17:02 PDT 
We already have a metabug tracking this work, and we ended up using IntPoint instead of IntSize.