Bug 60633 - WebKit1 loads Windows Presentation Foundation plugin, but should not
Summary: WebKit1 loads Windows Presentation Foundation plugin, but should not
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-05-11 09:18 PDT by Adam Roben (:aroben)
Modified: 2011-05-11 09:57 PDT (History)
3 users (show)

See Also:

Attachments
Use case-insensitive comparisons when checking plugin filenames on Windows (1.99 KB, patch)
2011-05-11 09:51 PDT, Adam Roben (:aroben) 		sfalken: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-05-11 09:18:32 PDT 
I have a Windows Presentation Foundation (WPF) plugin installed on my Windows XP machine. WebKit1 is loading it, WebKit2 is not. It's listed in the MozillaPlugins registry key with the path c:\WINDOWS\Microsoft.NET\Framework\v3.5\Windows Presentation Foundation\NPWPF.dll. I don't know why WebKit2 isn't loading it!
Comment 1 Adam Roben (:aroben) 2011-05-11 09:22:53 PDT 
Ah, we have code that explicitly blacklists this plugin. A comment references bug 57119.
Comment 2 Adam Roben (:aroben) 2011-05-11 09:23:56 PDT 
So we're intentionally not loading it. The bug, then, is that WebKit1 *is* loading it!
Comment 3 Adam Roben (:aroben) 2011-05-11 09:24:16 PDT 
I think the problem is that WebKit1 is doing a case-sensitive filename check, rather than case-insensitive.
Comment 4 Adam Roben (:aroben) 2011-05-11 09:28:19 PDT 
On my system, the filename is "NPWPF.dll", but WebKit1 is checking for "npwpf.dll".
Comment 5 Adam Roben (:aroben) 2011-05-11 09:51:09 PDT 
Created attachment 93136 [details]
Use case-insensitive comparisons when checking plugin filenames on Windows
Comment 6 Adam Roben (:aroben) 2011-05-11 09:57:20 PDT 
Committed r86242: <http://trac.webkit.org/changeset/86242>