RESOLVED FIXED 57119
Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll 
https://bugs.webkit.org/show_bug.cgi?id=57119
Summary Microsoft Windows Presentation Foundation (WPF) plug-in complains about missi...
Steve Falkenburg
Reported Friday, March 25, 2011 9:39:07 PM UTC
Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll. This DLL links against a Firefox-specific library, and should be blacklisted, since this library won't be present in WebKit.
Attachments
Patch (2.96 KB, patch)
2011-03-25 13:52 PDT, Steve Falkenburg 		bweinstein: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Falkenburg
Comment 1 Friday, March 25, 2011 9:39:48 PM UTC
Plug-in DLL name is: NPWPF.DLL. We should just blacklist by DLL name.
Steve Falkenburg
Comment 2 Friday, March 25, 2011 9:42:06 PM UTC
<rdar://problem/9054148>
Steve Falkenburg
Comment 3 Friday, March 25, 2011 9:52:15 PM UTC
Created attachment 86979 [details] Patch
Brian Weinstein
Comment 4 Friday, March 25, 2011 9:55:55 PM UTC
Comment on attachment 86979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86979&action=review > Source/WebCore/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=57119 Radar link? > Source/WebCore/plugins/win/PluginPackageWin.cpp:78 > + // Bug 57119: Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll It might be nice to say that this is a Mozilla only DLL. > Source/WebKit2/ChangeLog:7 > + Ditto about radar link. > Source/WebKit2/UIProcess/Plugins/win/PluginInfoStoreWin.cpp:364 > + // Bug 57119: Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll Ditto about Mozilla-only DLL.
Steve Falkenburg
Comment 5 Friday, March 25, 2011 10:05:39 PM UTC
Committed r81989: <http://trac.webkit.org/changeset/81989>
Adam Roben (:aroben)
Comment 6 Wednesday, May 11, 2011 5:30:44 PM UTC
Looks like this patch wasn't quite right. See bug 60633.
Note You need to log in before you can comment on or make changes to this bug.