Bug 57119 - Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll
Summary: Microsoft Windows Presentation Foundation (WPF) plug-in complains about missi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-03-25 13:39 PDT by Steve Falkenburg
Modified: 2011-05-11 09:30 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.96 KB, patch)
2011-03-25 13:52 PDT, Steve Falkenburg
bweinstein: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2011-03-25 13:39:07 PDT
Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll.

This DLL links against a Firefox-specific library, and should be blacklisted, since this library won't be present in WebKit.
Comment 1 Steve Falkenburg 2011-03-25 13:39:48 PDT
Plug-in DLL name is: NPWPF.DLL.
We should just blacklist by DLL name.
Comment 2 Steve Falkenburg 2011-03-25 13:42:06 PDT
<rdar://problem/9054148>
Comment 3 Steve Falkenburg 2011-03-25 13:52:15 PDT
Created attachment 86979 [details]
Patch
Comment 4 Brian Weinstein 2011-03-25 13:55:55 PDT
Comment on attachment 86979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86979&action=review

> Source/WebCore/ChangeLog:6
> +        https://bugs.webkit.org/show_bug.cgi?id=57119

Radar link?

> Source/WebCore/plugins/win/PluginPackageWin.cpp:78
> +        // Bug 57119: Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll

It might be nice to say that this is a Mozilla only DLL.

> Source/WebKit2/ChangeLog:7
> +

Ditto about radar link.

> Source/WebKit2/UIProcess/Plugins/win/PluginInfoStoreWin.cpp:364
> +        // Bug 57119: Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll

Ditto about Mozilla-only DLL.
Comment 5 Steve Falkenburg 2011-03-25 14:05:39 PDT
Committed r81989: <http://trac.webkit.org/changeset/81989>
Comment 6 Adam Roben (:aroben) 2011-05-11 09:30:44 PDT
Looks like this patch wasn't quite right. See bug 60633.