Bug 60592 - Convert RenderFlexibleBox to use IntPoint/IntSize instead of x,y/w,h pairs
: Convert RenderFlexibleBox to use IntPoint/IntSize instead of x,y/w,h pairs
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering
: 528+ (Nightly build)
: All All
: P3 Enhancement
Assigned To: Nobody
:
Depends on:
Blocks: 60318
  Show dependency treegraph
 
Reported: 2011-05-10 15:41 PDT by Emil A Eklund
Modified: 2011-05-11 10:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (5.63 KB, patch)
2011-05-10 17:38 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2011-05-10 15:41:41 PDT
Convert RenderFlexibleBox to use IntPoint instead of x,y pairs and IntSize instead of width,height pairs.
Comment 1 Emil A Eklund 2011-05-10 17:38:55 PDT
Created attachment 93056 [details]
Patch
Comment 2 Eric Seidel 2011-05-10 22:11:08 PDT
Comment on attachment 93056 [details]
Patch

LGTM.  The + IntSize(0, offset) stuff reads a little strangely, but this looks like an improvement.
Comment 3 WebKit Commit Bot 2011-05-11 00:11:29 PDT
Comment on attachment 93056 [details]
Patch

Clearing flags on attachment: 93056

Committed r86222: <http://trac.webkit.org/changeset/86222>
Comment 4 WebKit Commit Bot 2011-05-11 00:11:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2011-05-11 02:07:14 PDT
http://trac.webkit.org/changeset/86222 might have broken Windows XP Debug (Tests)
Comment 6 Darin Adler 2011-05-11 09:20:04 PDT
Comment on attachment 93056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93056&action=review

> Source/WebCore/rendering/RenderFlexibleBox.h:53
> +    void placeChild(RenderBox* child, IntPoint location);

Normally we’d use const IntPoint& instead of just IntPoint to avoid extra constructor overhead.
Comment 7 Eric Seidel 2011-05-11 10:15:03 PDT
Ah, true.  My apologies for not catching that.  Thank you Darin.
Comment 8 Emil A Eklund 2011-05-11 10:32:57 PDT
Thanks Darin, I'll upload a patch for that later today, bug 60640.