Bug 60592 - Convert RenderFlexibleBox to use IntPoint/IntSize instead of x,y/w,h pairs
: Convert RenderFlexibleBox to use IntPoint/IntSize instead of x,y/w,h pairs
Status: RESOLVED FIXED
: WebKit
Layout and Rendering
: 528+ (Nightly build)
: All All
: P3 Enhancement
Assigned To:
:
:
:
: 60318
  Show dependency treegraph
 
Reported: 2011-05-10 15:41 PST by
Modified: 2011-05-11 10:32 PST (History)


Attachments
Patch (5.63 KB, patch)
2011-05-10 17:38 PST, Emil A Eklund
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-05-10 15:41:41 PST
Convert RenderFlexibleBox to use IntPoint instead of x,y pairs and IntSize instead of width,height pairs.
------- Comment #1 From 2011-05-10 17:38:55 PST -------
Created an attachment (id=93056) [details]
Patch
------- Comment #2 From 2011-05-10 22:11:08 PST -------
(From update of attachment 93056 [details])
LGTM.  The + IntSize(0, offset) stuff reads a little strangely, but this looks like an improvement.
------- Comment #3 From 2011-05-11 00:11:29 PST -------
(From update of attachment 93056 [details])
Clearing flags on attachment: 93056

Committed r86222: <http://trac.webkit.org/changeset/86222>
------- Comment #4 From 2011-05-11 00:11:33 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #5 From 2011-05-11 02:07:14 PST -------
http://trac.webkit.org/changeset/86222 might have broken Windows XP Debug (Tests)
------- Comment #6 From 2011-05-11 09:20:04 PST -------
(From update of attachment 93056 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=93056&action=review

> Source/WebCore/rendering/RenderFlexibleBox.h:53
> +    void placeChild(RenderBox* child, IntPoint location);

Normally we’d use const IntPoint& instead of just IntPoint to avoid extra constructor overhead.
------- Comment #7 From 2011-05-11 10:15:03 PST -------
Ah, true.  My apologies for not catching that.  Thank you Darin.
------- Comment #8 From 2011-05-11 10:32:57 PST -------
Thanks Darin, I'll upload a patch for that later today, bug 60640.