Bug 60528 - new-run-webkit-tests don't run platform specific tests when running subsets of tests
Summary: new-run-webkit-tests don't run platform specific tests when running subsets o...
Status: RESOLVED DUPLICATE of bug 37956
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 64491
  Show dependency treegraph
 
Reported: 2011-05-09 19:11 PDT by Ryosuke Niwa
Modified: 2012-06-08 16:07 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-05-09 19:11:35 PDT
Passing a directory name X to old-run-webkit-tests would run all tests in LayoutTests/X and LayoutTests/platform/Y/X where Y is the given platform but new-run-webkit-tests don't run the latter.
Comment 1 Tony Chang 2011-05-09 19:48:37 PDT
For chromium, this might be expected since we run all the tests on all platforms (unless skipped in test_expectations.txt).  I guess for chromium we should run LayoutTests/platform/*/X and for other platforms, match ORWT.
Comment 2 Dirk Pranke 2011-05-10 10:13:32 PDT
Actually, in a thread a couple weeks back I suggested that we change NRWT to match ORWT across the board (and stop running platform/* for Chromium), and nobody disagreed.

I have no problem matching ORWT here, although I was never aware of this particular behavior and it's a little surprising to me (I would think you would have to specify both directories if you wanted both directories). I don't feel particularly strongly about it one way or another.
Comment 3 Ryosuke Niwa 2011-05-10 10:18:30 PDT
(In reply to comment #2)
> Actually, in a thread a couple weeks back I suggested that we change NRWT to match ORWT across the board (and stop running platform/* for Chromium), and nobody disagreed.

I think that's better.  I don't like Chromium port doing different thing from other ports.  It just complicates things, confuse contributors from other ports, and adds maintenance cost.

> I have no problem matching ORWT here, although I was never aware of this particular behavior and it's a little surprising to me (I would think you would have to specify both directories if you wanted both directories). I don't feel particularly strongly about it one way or another.

It's really useful when you're writing some patch and want to sanity-test your patch against some subsets of tests (e.g. editing) since there's no easy way to tell which directory has platform-specific tests other than manually looking at the directories.
Comment 4 Adam Barth 2011-06-29 18:08:25 PDT
This doesn't need to block Bug 34984.
Comment 5 Dirk Pranke 2012-06-08 16:07:11 PDT
this is a duplicate of bug 37956, looks like.

*** This bug has been marked as a duplicate of bug 37956 ***