Bug 60506 - REGRESSION: drag caret isn't drawn in Mac DRT
Summary: REGRESSION: drag caret isn't drawn in Mac DRT
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Critical
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-09 14:40 PDT by Ryosuke Niwa
Modified: 2011-08-05 12:06 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-05-09 14:40:09 PDT
Mac DumpRenderTree has regressed and no longer draws drag caret:
http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/editing/selection/drag-in-iframe-expected.png

This is unrelated to the regression introduced in r86039, which is tracked in the bug 60505.

As far as I investigated, In mouseMoveToX (DumpRenderTree/mac/EventSendingController.mm), draggingInfo is null and draggingUpdated is never called.  Even if I forced to call draggingUpdated, dragData->containsCompatibleContent() returns false in DragController::canProcessDrag (which is in turn called by DragController::concludeEditDrag) and never sets drag caret.

Unfortunately, I don't know enough about Mac port to fix this regression.
Comment 1 Alexey Proskuryakov 2011-05-09 15:21:34 PDT
Do you happen to know what revision caused the regression? Perhaps it can be just reverted?
Comment 2 Alexey Proskuryakov 2011-05-09 15:22:03 PDT
Also, does this only affect DRT, or the browser, too?
Comment 3 Ryosuke Niwa 2011-05-09 15:28:55 PDT
(In reply to comment #1)
> Do you happen to know what revision caused the regression? Perhaps it can be just reverted?

Unfortunately no.  I'm suspecting http://trac.webkit.org/changeset/43890 but that's just my speculation.  It didn't help that Mac test bots don't run pixel tests.  We should add a drag caret position in render tree dump in the future so that render tree dump difference catch this kind of regression in the future.

(In reply to comment #2)
> Also, does this only affect DRT, or the browser, too?

This bug only affects DRT.  It's not updating DragCaretController properly.  However, there is a pending bug 60505 that broke this feature (due to this feature not being tested).