60469 – [Qt] Some skipped editing tests actually work and just need rebaseline.

Bug 60469 - [Qt] Some skipped editing tests actually work and just need rebaseline.

Summary: [Qt] Some skipped editing tests actually work and just need rebaseline.

Status:	RESOLVED LATER

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	528+ (Nightly build)
Hardware:	PC Linux

Importance:	P2 Normal
Assignee:	Chang Shu

URL:
Keywords:

Depends on:	60479 60498 60702 60707 60717 61075
Blocks:
	Show dependency tree / graph

Reported:	2011-05-09 08:26 PDT by Chang Shu
Modified:	2011-08-11 13:12 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
fix patch: part 1 (2.10 KB, patch) 2011-05-10 14:43 PDT, Chang Shu	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Chang Shu 2011-05-09 08:26:01 PDT

I am in the process of investigating editing tests on Qt. I noticed some tests are actually working but need a rebaseline.

Comment 1 Chang Shu 2011-05-09 08:27:52 PDT

editing/inserting/4278698.html
The above test works. Ossy, can you help to rebaseline it? Thanks.

Comment 2 Chang Shu 2011-05-09 08:36:14 PDT

editing/inserting/editable-html-element.html
this one works, too.

Comment 3 Chang Shu 2011-05-09 08:39:52 PDT

and this:
editing/inserting/editing-empty-divs.html

Comment 4 Chang Shu 2011-05-09 08:42:24 PDT

and this:
editing/inserting/insert-div-023.html

Comment 5 Chang Shu 2011-05-09 08:44:14 PDT

and this:
editing/inserting/multiple-lines-selected.html

Comment 6 Chang Shu 2011-05-10 11:58:01 PDT

editing/pasteboard/smart-paste-008.html

Comment 7 Chang Shu 2011-05-10 12:07:20 PDT

editing/pasteboard/nested-blocks-with-text-area.html

Comment 8 Chang Shu 2011-05-10 12:08:53 PDT

editing/pasteboard/nested-blocks-with-text-field.html

Comment 9 Chang Shu 2011-05-10 12:11:15 PDT

editing/pasteboard/input-field-1.html

Comment 10 Chang Shu 2011-05-10 12:12:44 PDT

editing/pasteboard/4806874.html

Comment 11 Chang Shu 2011-05-10 13:36:19 PDT

editing/pasteboard/5387578.html

Comment 12 Chang Shu 2011-05-10 13:37:40 PDT

editing/pasteboard/bad-placeholder.html

Comment 13 Chang Shu 2011-05-10 13:39:38 PDT

editing/pasteboard/4076267.html

Comment 14 Chang Shu 2011-05-10 13:40:15 PDT

editing/pasteboard/4076267-2.html

Comment 15 Chang Shu 2011-05-10 13:53:05 PDT

editing/pasteboard/block-wrappers-necessary.html

Comment 16 Chang Shu 2011-05-10 13:56:11 PDT

editing/pasteboard/paste-text-001.html
editing/pasteboard/4242293-1.html

these two work out-of-box. just upskip them.

Comment 17 Chang Shu 2011-05-10 13:56:24 PDT

editing/pasteboard/paste-text-008.html

Comment 18 Chang Shu 2011-05-10 13:59:54 PDT

editing/pasteboard/paste-text-at-tabspan-001.html
editing/pasteboard/onpaste-text-html-types.html

These two also work fine. Unskip.

Comment 19 Chang Shu 2011-05-10 14:43:13 PDT

Created attachment 93009 [details]
fix patch: part 1

Comment 20 Csaba Osztrogonác 2011-05-11 07:22:03 PDT

Comment on attachment 93009 [details]
fix patch: part 1

r=me

Comment 21 WebKit Commit Bot 2011-05-11 09:04:30 PDT

The commit-queue encountered the following flaky tests while processing attachment 93009 [details]:

http/tests/xmlhttprequest/basic-auth.html bug 51613 (authors: ap@webkit.org and eric@webkit.org)
The commit-queue is continuing to process your patch.

Comment 22 WebKit Commit Bot 2011-05-11 09:05:37 PDT

Comment on attachment 93009 [details]
fix patch: part 1

Clearing flags on attachment: 93009

Committed r86235: <http://trac.webkit.org/changeset/86235>

Comment 23 WebKit Commit Bot 2011-05-11 09:05:43 PDT

All reviewed patches have been landed.  Closing bug.

Comment 24 Chang Shu 2011-05-11 09:08:05 PDT

more patches coming...

Comment 25 Eric Seidel (no email) 2011-05-11 10:18:01 PDT

Generally we do one-patch per-bug and use meta bugs.  Then again, you're welcome to use bugzilla however you wish.  :)  Our tools are obviously optimized for hte one-patch-per-bug workflow.

Comment 26 Chang Shu 2011-05-11 10:27:08 PDT

(In reply to comment #25)
> Generally we do one-patch per-bug and use meta bugs.  Then again, you're welcome to use bugzilla however you wish.  :)  Our tools are obviously optimized for hte one-patch-per-bug workflow.

Thanks, Eric. I understand. This bug is slightly special. You can consider it a meta bug. But since it's just rebaseline, I didn't plan to create separate bugs for each patch. It also takes time to investigate each test case, so I can't do everything in one patch. But if this confuses people, I will create separate bugs in the future.

Comment 27 Ademar Reis 2011-05-13 10:53:36 PDT

We had some changes in our DRT on trunk and it's not "safe" to cherry-pick layout tests to qtwebkit-2.2 anymore (not without auditing the changes). 

I'm removing them from the meta-bug (they were not critical anyway, just a nice-to-have).

Comment 28 Chang Shu 2011-08-11 13:12:02 PDT

This task can be resumed later.