RESOLVED FIXED 60702
[Qt] Rebaseline editing/inserting tests that work 
https://bugs.webkit.org/show_bug.cgi?id=60702
Summary [Qt] Rebaseline editing/inserting tests that work
Chang Shu
Reported 2011-05-12 08:46:34 PDT
The following tests are verified working ok. editing/inserting/4278698.html editing/inserting/editable-html-element.html editing/inserting/editing-empty-divs.html editing/inserting/insert-div-023.html editing/inserting/multiple-lines-selected.html
Attachments
fix patch (145.54 KB, patch)
2011-05-12 09:19 PDT, Chang Shu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 2011-05-12 09:19:07 PDT
Created attachment 93294 [details] fix patch
Csaba Osztrogonác
Comment 2 2011-05-12 09:37:34 PDT
Comment on attachment 93294 [details] fix patch View in context: https://bugs.webkit.org/attachment.cgi?id=93294&action=review > LayoutTests/platform/qt/Skipped:331 > +editing/inserting/typing-at-end-of-line.html Why did you add a new test to the Skipped list?
Chang Shu
Comment 3 2011-05-12 10:05:28 PDT
> > LayoutTests/platform/qt/Skipped:331 > > +editing/inserting/typing-at-end-of-line.html > > Why did you add a new test to the Skipped list? I just found this is a new test and checked it's failing.
WebKit Commit Bot
Comment 4 2011-05-12 10:35:59 PDT
Comment on attachment 93294 [details] fix patch Clearing flags on attachment: 93294 Committed r86357: <http://trac.webkit.org/changeset/86357>
WebKit Commit Bot
Comment 5 2011-05-12 10:36:03 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2011-05-12 11:50:34 PDT
http://trac.webkit.org/changeset/86357 might have broken SnowLeopard Intel Release (WebKit2 Tests) The following tests are not passing: fast/lists/inlineBoxWrapperNullCheck.html
Chang Shu
Comment 7 2011-05-12 11:54:07 PDT
(In reply to comment #6) > http://trac.webkit.org/changeset/86357 might have broken SnowLeopard Intel Release (WebKit2 Tests) > The following tests are not passing: > fast/lists/inlineBoxWrapperNullCheck.html not this patch.
Note You need to log in before you can comment on or make changes to this bug.