Bug 60342 - [chromium] Skia: Visible corner seam artifacts painting CSS outline property
Summary: [chromium] Skia: Visible corner seam artifacts painting CSS outline property
Status: RESOLVED DUPLICATE of bug 61369
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 61369
Blocks:
  Show dependency tree / graph
 
Reported: 2011-05-05 23:04 PDT by Ben Wells
Modified: 2011-07-27 21:52 PDT (History)
5 users (show)

See Also:

Attachments
Test case (170 bytes, text/html)
2011-05-05 23:04 PDT, Ben Wells 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Wells 2011-05-05 23:04:33 PDT 
Created attachment 92545 [details]
Test case

Test case attached.
Comment 1 Ben Wells 2011-05-05 23:08:53 PDT 
http://crbug.com/81777
Comment 2 Ben Wells 2011-05-05 23:23:51 PDT 
Outline sides are drawn by GraphicsContext::drawConvexPolygon, with the shouldAntialias flag set false. This works on CG. If I change skia's implementation by adding one line

    paint.setAntiAlias(shouldAntialias);

the artifacts in the corner seams / joins go away. Would this cause any problems with the work you're doing on borders?
Comment 3 Ben Wells 2011-05-06 00:28:14 PDT 
The GraphicsContext::drawConvexPolygon is also used when drawing borders and changing it also changes how borders are drawn. In particular seams in borders between two colors no longer use anti-aliasing. 

The old border code in RenderBoxModelObject (defined out by PATH_BASED_BORDER_RADIUS_DRAWING) always calls drawConvexPolygon with shouldAntialias off. 

This is why there is a difference in test css2.1/t0805-c5516-brdr-c-00-a.html noted in bug 41311.
Comment 4 Ben Wells 2011-05-08 18:55:15 PDT 
http://crbug.com/10354
Comment 5 Ben Wells 2011-05-11 22:11:32 PDT 
When this bug is fixed, the #if !USE(SKIA) blocks in outline drawing in RenderObject.cpp and RenderInline.cpp should be removed to fix bug 58999 for skia.
Comment 6 Ben Wells 2011-07-27 21:52:44 PDT 

*** This bug has been marked as a duplicate of bug 61369 ***