Bug 60223 - The testing EWS bots should upload layout-test-results.zip to bugs after failures
Summary: The testing EWS bots should upload layout-test-results.zip to bugs after fail...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
Depends on: 74929
  Show dependency treegraph
Reported: 2011-05-04 16:00 PDT by Eric Seidel (no email)
Modified: 2012-05-14 05:09 PDT (History)
5 users (show)

See Also:

Patch (13.30 KB, patch)
2011-05-04 16:01 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-05-04 16:00:18 PDT
The testing EWS bots should upload layout-test-results.zip to bugs after failures
Comment 1 Eric Seidel (no email) 2011-05-04 16:01:20 PDT
Created attachment 92337 [details]
Comment 2 Adam Barth 2011-05-04 16:06:04 PDT
Comment on attachment 92337 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=92337&action=review

> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:188
>      @classmethod
>      def handle_script_error(cls, tool, state, script_error):
> +        # FIXME: Why does this not exit(1) like the superclass does?
>          log(script_error.message_with_output())

Probably a bug.

> Tools/Scripts/webkitpy/tool/commands/queues.py:242
> +    # FIXME: This probably belongs at a layer above AbstractPatchQueue, but shared by CommitQueue and the EarlyWarningSystem.

above => below.
Comment 3 Eric Seidel (no email) 2011-05-04 16:22:13 PDT
Committed r85802: <http://trac.webkit.org/changeset/85802>
Comment 4 Eric Seidel (no email) 2011-05-04 16:23:19 PDT
There were a few random git.py fixes which got rolled into this as I successfully made it possible to commit while not being in your git checkout.  The rest of webkit-patch is designed to work even when your PWD is not inside a git tree, so landing should too. :)  Turns out there were an epic number of places where we were missing cwd=self.checkout_root!
Comment 5 Csaba Osztrogonác 2012-04-03 08:19:51 PDT
Reopened, because it killed the Qt EWS. See https://bugs.webkit.org/show_bug.cgi?id=74929 for details. 

I don't think if it is a good idea to upload 8-10 Mb sizes diffs to the bugzilla as attachment many times. For example there are 73 Mb sizes EWS
attachment in https://bugs.webkit.org/show_bug.cgi?id=25206 and its XML 
size is 105Mb. And unfortunately EWS tries to fetch the whole bug 3 times.

It would be better if EWS uploads the results to an other 
storage, and adds only its URL to the bugzilla as comment.
Comment 6 Adam Barth 2012-04-03 10:00:41 PDT
We really should filter files out of the zip so it's just the interesting ones.  That should cut down on the size dramatically.
Comment 7 Eric Seidel (no email) 2012-04-03 12:30:28 PDT
As far as I know, bugzilla did not use to inline attachments into the XML.  Since it's started doing that, EWS speeds have gone way down.  We either need to move away from ctype=xml, or find a way to tell bugzilla not to inline (base64 encoded) attachments into the ctype=xml response.
Comment 8 Csaba Osztrogonác 2012-05-14 05:09:24 PDT
The bug is fixed in https://bugs.webkit.org/show_bug.cgi?id=74929 . (https://trac.webkit.org/changeset/116934)