Add compile-guarded modifications to the Track List objects to make them fully compatible with their use in the Media Stream API. Update also the controllers to provide these lists on stream generation.
Created attachment 95421 [details] Patch
Comment on attachment 95421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95421&action=review Just a nit and a question, everything else looks good to me. > Source/WebCore/dom/ExclusiveTrackList.cpp:73 > +void ExclusiveTrackList::trackFailed(unsigned long index) It isn't obvious to me why mediaStreamFrameController doesn't need to be notified. > Source/WebCore/dom/TrackList.cpp:167 > // For the HTML Media Element: https://bugs.webkit.org/show_bug.cgi?id=61127 This comment has a redundant "for the HTML Media Element" now.
Comment on attachment 95421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95421&action=review >> Source/WebCore/dom/ExclusiveTrackList.cpp:73 >> +void ExclusiveTrackList::trackFailed(unsigned long index) > > It isn't obvious to me why mediaStreamFrameController doesn't need to be notified. It is. In fact the MediaStreamFrameController is the one calling this method. Just look for MediaStreamFrameController::audioTrackFailed and MediaStreamFrameController::videoTrackFailed. Is that what you mean?
> It is. In fact the MediaStreamFrameController is the one calling this method. Just look for MediaStreamFrameController::audioTrackFailed and MediaStreamFrameController::videoTrackFailed. Is that what you mean? Thanks for the explanation. Looks good.
Comment on attachment 95421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95421&action=review >> Source/WebCore/dom/TrackList.cpp:167 >> // For the HTML Media Element: https://bugs.webkit.org/show_bug.cgi?id=61127 > > This comment has a redundant "for the HTML Media Element" now. Removed.
Created attachment 96405 [details] Patch
Comment on attachment 96405 [details] Patch Clearing flags on attachment: 96405 Committed r88341: <http://trac.webkit.org/changeset/88341>
All reviewed patches have been landed. Closing bug.
Changed platform to All/All