Mac WebKit port should be creating PlatformMouseEvent in WebKit code instead of pushing that code into EventHandler.
Created attachment 91749 [details] cleanup
Created attachment 91758 [details] Fixed test failures
Apparently PlatformMouseEvent(event, self) and PlatformMouseEvent(event, page->chrome()->platformPageClient()) are different in WebHTMLView.mm
Comment on attachment 91758 [details] Fixed test failures View in context: https://bugs.webkit.org/attachment.cgi?id=91758&action=review SGTM. > Source/WebKit/mac/WebView/WebHTMLView.mm:3456 > + if (Page* page = coreFrame->page()) > + result = coreFrame->eventHandler()->eventMayStartDrag(PlatformMouseEvent(event, page->chrome()->platformPageClient())); Will results still end up as false in the !page() case after this change?
Comment on attachment 91758 [details] Fixed test failures View in context: https://bugs.webkit.org/attachment.cgi?id=91758&action=review Thanks for the review! >> Source/WebKit/mac/WebView/WebHTMLView.mm:3456 >> + result = coreFrame->eventHandler()->eventMayStartDrag(PlatformMouseEvent(event, page->chrome()->platformPageClient())); > > Will results still end up as false in the !page() case after this change? Yes, result is initialized to false.
Comment on attachment 91758 [details] Fixed test failures Clearing flags on attachment: 91758 Committed r85428: <http://trac.webkit.org/changeset/85428>
All reviewed patches have been landed. Closing bug.