Bug 56410 - EventHandler needs cleanup
Summary: EventHandler needs cleanup
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on: 58470 59553 59555 59556 58472 58503 59580 59835 59837 60200 60228
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-15 13:44 PDT by Ryosuke Niwa
Modified: 2011-05-04 20:08 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-03-15 13:44:12 PDT
EventHandler has many duplicated code and long functions.  This entire class needs to be refactored and cleaned up.
Comment 1 Sam Weinig 2011-03-20 12:00:04 PDT
If we are going to undertake cleaning up EventHandler, which is an extremely laudable goal and needs to be done, we should consider making some changes to its design as well. For instance, does it really need to be per-frame, or can we make it per Page?
Comment 2 Ryosuke Niwa 2011-03-22 12:44:20 PDT
(In reply to comment #1)
> If we are going to undertake cleaning up EventHandler, which is an extremely laudable goal and needs to be done, we should consider making some changes to its design as well. For instance, does it really need to be per-frame, or can we make it per Page?

It does store some states so we'll be changing the behavior if we're moving it to Page-level.  I guess we'll need to investigate per feature basis.  It might even be that we need two separate classes for Page-level and Frame-level states.
Comment 3 Dimitri Glazkov (Google) 2011-03-26 21:20:56 PDT
Some of the bits from EventHandler should be moved to EventDispatcher, which is being birthed in bug 57168.