NEW 56410
EventHandler needs cleanup 
https://bugs.webkit.org/show_bug.cgi?id=56410
Summary EventHandler needs cleanup
Ryosuke Niwa
Reported 2011-03-15 13:44:12 PDT
EventHandler has many duplicated code and long functions. This entire class needs to be refactored and cleaned up.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-03-20 12:00:04 PDT
If we are going to undertake cleaning up EventHandler, which is an extremely laudable goal and needs to be done, we should consider making some changes to its design as well. For instance, does it really need to be per-frame, or can we make it per Page?
Ryosuke Niwa
Comment 2 2011-03-22 12:44:20 PDT
(In reply to comment #1) > If we are going to undertake cleaning up EventHandler, which is an extremely laudable goal and needs to be done, we should consider making some changes to its design as well. For instance, does it really need to be per-frame, or can we make it per Page? It does store some states so we'll be changing the behavior if we're moving it to Page-level. I guess we'll need to investigate per feature basis. It might even be that we need two separate classes for Page-level and Frame-level states.
Dimitri Glazkov (Google)
Comment 3 2011-03-26 21:20:56 PDT
Some of the bits from EventHandler should be moved to EventDispatcher, which is being birthed in bug 57168.
Note You need to log in before you can comment on or make changes to this bug.