Bug 59797 - Web Inspector: [STYLES] Lazily build computed trace to speed up switching between elements in the Elements panel
Summary: Web Inspector: [STYLES] Lazily build computed trace to speed up switching bet...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-29 08:47 PDT by Alexander Pavlov (apavlov)
Modified: 2011-06-14 04:44 PDT (History)
10 users (show)

See Also:


Attachments
[PATCH] Suggested solution (5.98 KB, patch)
2011-04-29 10:34 PDT, Alexander Pavlov (apavlov)
pfeldman: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2011-04-29 08:47:46 PDT
Currently, the computed trace is built even if the Computed Styles pane is collapsed.
Patch to follow.
Comment 1 Alexander Pavlov (apavlov) 2011-04-29 10:34:18 PDT
Created attachment 91697 [details]
[PATCH] Suggested solution
Comment 2 Pavel Feldman 2011-04-30 02:24:08 PDT
Comment on attachment 91697 [details]
[PATCH] Suggested solution

View in context: https://bugs.webkit.org/attachment.cgi?id=91697&action=review

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:515
> +                section.expanded = this._computedStylePane.expanded;

style rule sections should never be collapsed. if you fine one that is, please fix it in its constructor.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:519
> +                section.expanded = true;

ditto

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:667
> +        if (!this.section.expanded)

ditto
Comment 3 Alexander Pavlov (apavlov) 2011-06-14 04:44:45 PDT
This issue is covered by bug 60813.