Bug 60813 – Web Inspector: node selection is slow in the Elements panel.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

- Open a large site with many nested nodes / tables
- Press and hold Up or Down key for several seconds

inspector is not catching up with the load.

We should
1) speed up styles processing
2) either delay style sidebar update or make it not update until the arrow key is released.

[Alexander Pavlov (apavlov)]

Created attachment 94801 [details]
[PATCH] Suggested solution

[WebKit Review Bot]

Comment on attachment 94801 [details]
[PATCH] Suggested solution

Attachment 94801 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8729927

New failing tests:
inspector/styles/styles-iframe.html
inspector/styles/styles-url-linkify.html
inspector/elements/elements-panel-styles.html
http/tests/inspector/inspect-iframe-from-different-domain.html

[WebKit Review Bot]

Created attachment 94809 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Yury Semikhatsky]

Comment on attachment 94801 [details]
[PATCH] Suggested solution

View in context: https://bugs.webkit.org/attachment.cgi?id=94801&action=review

Chromium tests failed, r- for now.

> LayoutTests/inspector/styles/styles-update-from-js.html:51
>                      next();

Why is this callback different from the one in testSetStyleAttribute ?

[Alexander Pavlov (apavlov)]

Created attachment 95186 [details]
[PATCH] Attempt to fix tests failing on cr-linux

[Alexander Pavlov (apavlov)]

Created attachment 95340 [details]
[PATCH] Fixed inspector/styles/styles-update-from-js.html test to avoid the double-callback-hit workaround

[Yury Semikhatsky]

Comment on attachment 95340 [details]
[PATCH] Fixed inspector/styles/styles-update-from-js.html test to avoid the double-callback-hit workaround

View in context: https://bugs.webkit.org/attachment.cgi?id=95340&action=review

> LayoutTests/inspector/styles/styles-update-from-js.html:5
> +<script src="../../http/tests/inspector/console-test.js"></script>

Is it really needed?

[Alexander Pavlov (apavlov)]

Committed r87683: <http://trac.webkit.org/changeset/87683>

[Alexander Pavlov (apavlov)]

Rolled out in r87686 (breaks inspector tests on Chromium)

[Alexander Pavlov (apavlov)]

Created attachment 96234 [details]
[PATCH] Tentatively fixed inspector test failures on Chromium

[Alexander Pavlov (apavlov)]

Committed r88238: <http://trac.webkit.org/changeset/88238>

[Alexander Pavlov (apavlov)]

Committed r88337: <http://trac.webkit.org/changeset/88337>

[Ryosuke Niwa]

A test added by this patch is failing on GTK:
http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r88596%20(14594)/results.html

 Modified cssText
-<div id="container" style="color: rgb(192, 255, 238); "></div>
+<div id="container" style="color: #daC0DE; border: 1px solid black;"></div>
 [expanded] element.style { ()
 color: #C0FFEE;

[Pavel Feldman]

Rolled out as r88337.

[Pavel Feldman]

Created attachment 98680 [details]
Patch

[Pavel Feldman]

Committed r89806: <http://trac.webkit.org/changeset/89806>