Bug 5975 - WebCore needs to use KDOM-like DOM binding autogeneration
Summary: WebCore needs to use KDOM-like DOM binding autogeneration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P4 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 6737
Blocks: 4249
  Show dependency treegraph
 
Reported: 2005-12-06 04:26 PST by Eric Seidel (no email)
Modified: 2006-01-25 13:55 PST (History)
0 users

See Also:


Attachments
First cut (66.32 KB, patch)
2006-01-23 15:40 PST, Anders Carlsson
darin: review+
Details | Formatted Diff | Diff
Address comments (65.08 KB, patch)
2006-01-24 12:53 PST, Anders Carlsson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-12-06 04:26:12 PST
WebCore needs to use KDOM-like DOM binding autogeneration

This is required to make KSVG DOM bindings work again.
Comment 1 Eric Seidel (no email) 2005-12-22 02:34:23 PST
Anders is actually working on this one.
Comment 2 Anders Carlsson 2006-01-23 15:40:36 PST
Created attachment 5892 [details]
First cut

Here's a first cut. I've never done anything serious in Perl before so there are probably things which can be done much better...
Comment 3 Darin Adler 2006-01-23 19:29:37 PST
Comment on attachment 5892 [details]
First cut

Two thoughts:

   1) I think the .idl files should probably go right alongside the actual source files rather than in the bindings directories.
    2) I'd much prefer a solution that puts the files into the DerivedSources directory, even if we compile all the bindings in one big include file at once.

But this is a great first step. r=me
Comment 4 Anders Carlsson 2006-01-24 12:53:56 PST
Created attachment 5923 [details]
Address comments

Here's a new patch that addresses both comments.
Comment 5 Darin Adler 2006-01-24 13:06:16 PST
Comment on attachment 5923 [details]
Address comments

Don't forget to put copyright and license information in the patch.

I'm not clear on why we need to use /usr/bin/env to invoke perl.

JavaScript has a capital S and that's not right in the Xcode project.

Looks fine, r=me.