Bug 4249 - SVG JavaScript bindings are busted in latest WebCore+SVG
Summary: SVG JavaScript bindings are busted in latest WebCore+SVG
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords: SVGHitList
Depends on: 5975
Blocks: 4624 9190
  Show dependency treegraph
 
Reported: 2005-08-01 03:13 PDT by Eric Seidel (no email)
Modified: 2006-05-31 20:42 PDT (History)
3 users (show)

See Also:


Attachments
One example of a busted SVG (which used to work) (2.32 KB, image/svg+xml)
2005-08-01 03:15 PDT, Eric Seidel (no email)
no flags Details
First stab and turning some of these back on (142.20 KB, patch)
2006-05-30 04:15 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Much better patch, ready for review. (330.65 KB, patch)
2006-05-30 14:58 PDT, Eric Seidel (no email)
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-08-01 03:13:49 PDT
REGRESSION: JavaScript support is busted in WebCore+SVG

JavaScript used to work fine in WebCore+SVG.  I believe this was a result of mjs JavaScriptCore 
optimizations.  (http://bugzilla.opendarwin.org/show_bug.cgi?id=4124)
Comment 1 Eric Seidel (no email) 2005-08-01 03:15:00 PDT
Created attachment 3192 [details]
One example of a busted SVG (which used to work)
Comment 2 Eric Seidel (no email) 2005-08-28 02:49:21 PDT
Ben is working on this one.
Comment 3 Eric Seidel (no email) 2005-12-06 04:24:30 PST
Actually, this is going to require more heavy lifting than ben will be able to give us.  Maciej or I need to re-
work the underlying WebCore javascript bindings to be autogenerated, and then make SVG use those 
autogenerated bindings as well.  With KDOM now removed from WebCore+SVG it's no longer possible for 
the SVG javascript bindings to sit on top of KDOM's bindings, but rather they need to be ported over to 
WebCore's once WebCore's bindings are fixed to be autogenerated.
Comment 4 Joost de Valk (AlthA) 2006-01-22 04:34:06 PST
Adding Regression keyword.
Comment 5 Eric Seidel (no email) 2006-01-25 14:21:26 PST
Basic DOM autobinding support has been landed. It will probably be a couple more weeks before it's ready to support SVG however.
Comment 6 Eric Seidel (no email) 2006-01-26 14:27:30 PST
Marking as P2, and adding to the SVG HitList.  We could never ship SVG w/o some form of SVG JS bindings.
Comment 7 Eric Seidel (no email) 2006-05-30 04:15:13 PDT
Created attachment 8601 [details]
First stab and turning some of these back on

This patch is not quite ready for review.  I'm posting it hear for discussion purposes.
Comment 8 Eric Seidel (no email) 2006-05-30 14:58:26 PDT
Created attachment 8610 [details]
Much better patch, ready for review.

This patch also has some various style cleanups (sorry).
Comment 9 Anders Carlsson 2006-05-31 08:14:21 PDT
Comment on attachment 8610 [details]
Much better patch, ready for review.

Some comments:

-    if (@{$dataNode->parents} > 1) {
-        die "A class can't have more than one parent";
-    }
+    #if (@{$dataNode->parents} > 1) {
+    #    die "A class can't have more than one parent";
+    #}

There should be a comment explaining why this is commented out.

I think the IDL files should be LGPL