Bug 59659 - Make GraphicsContext3DChromium play nice with strict OwnPtrs
Summary: Make GraphicsContext3DChromium play nice with strict OwnPtrs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 59434 59459 59487
Blocks:
  Show dependency tree / graph
 
Reported: 2011-04-27 16:56 PDT by Adam Barth
Modified: 2011-04-27 17:49 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2011-04-27 16:56 PDT, Adam Barth 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-04-27 16:56:18 PDT 
Make GraphicsContext3DChromium play nice with strict OwnPtrs
Comment 1 Adam Barth 2011-04-27 16:56:57 PDT 
Created attachment 91385 [details]
Patch
Comment 2 David Levin 2011-04-27 17:06:25 PDT 
Comment on attachment 91385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91385&action=review

> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:112
> +    OwnPtr<WebKit::WebGraphicsContext3D> webContext = adoptPtr(WebKit::webKitClient()->createGraphicsContext3D());

Since it is part of webKitClient we can't change it to return PassOwnPtr?
Comment 3 Adam Barth 2011-04-27 17:14:49 PDT 
Comment on attachment 91385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91385&action=review

>> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:112
>> -    WebKit::WebGraphicsContext3D* webContext = WebKit::webKitClient()->createGraphicsContext3D();
>> +    OwnPtr<WebKit::WebGraphicsContext3D> webContext = adoptPtr(WebKit::webKitClient()->createGraphicsContext3D());
> 
> Since it is part of webKitClient we can't change it to return PassOwnPtr?

I don't think we can use PassOwnPtr in WebKitClient.h.  That code needs to be free of WebCore types.
Comment 4 Adam Barth 2011-04-27 17:17:35 PDT 
Committed r85126: <http://trac.webkit.org/changeset/85126>