Bug 59487 - OwnPtr assignment operator should be private
Summary: OwnPtr assignment operator should be private
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 59459 59659
  Show dependency treegraph
 
Reported: 2011-04-26 13:49 PDT by Adam Barth
Modified: 2011-04-27 17:49 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.02 KB, patch)
2011-04-26 13:50 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-04-26 13:49:16 PDT
OwnPtr assignment operator should be private
Comment 1 Adam Barth 2011-04-26 13:50:42 PDT
Created attachment 91150 [details]
Patch
Comment 2 Kenneth Russell 2011-04-26 14:05:36 PDT
Comment on attachment 91150 [details]
Patch

This is important to fix as it allowed https://bugs.webkit.org/show_bug.cgi?id=59459 to creep in during the strict OwnPtr cleanup yesterday. I wonder whether it's worth a comment directly above the new private assignment operator indicating why it's necessary. Looks good to me otherwise.
Comment 3 WebKit Commit Bot 2011-04-27 00:14:16 PDT
The commit-queue encountered the following flaky tests while processing attachment 91150 [details]:

java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org)
http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2011-04-27 00:15:58 PDT
Comment on attachment 91150 [details]
Patch

Clearing flags on attachment: 91150

Committed r85028: <http://trac.webkit.org/changeset/85028>
Comment 5 WebKit Commit Bot 2011-04-27 00:16:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2011-04-27 01:01:50 PDT
http://trac.webkit.org/changeset/85028 might have broken Chromium Win Release