Bug 59281 – REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Hajime Morrita]

From Bug 58149.

[Hajime Morrita]

Created attachment 90860 [details]
Patch

[Adam Barth]

Looks like this patch causes fast/dom/HTMLMeterElement/meter-element.html to fail.

[Hajime Morrita]

(In reply to comment #2)
> Looks like this patch causes fast/dom/HTMLMeterElement/meter-element.html to fail.
Sounds false positive. That test is which exactly this change is trying to fix....

[Kent Tamura]

Comment on attachment 90860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90860&action=review

> Source/WebCore/ChangeLog:8
> +        style for -webkit-meter-bar and -webkit-progress-bar missed width property, which caused unexpected layout result

style -> Style

[Adam Barth]

> Sounds false positive. That test is which exactly this change is trying to fix....

Interesting.  Running the tests on the cr-linux-ews is very new.  It's entirely possible that this is a false positive.

[Hajime Morrita]

Kent-san, thank you for reviewing at the weekend :D
I'll fix it before landing.

Adam,
> > Sounds false positive. That test is which exactly this change is trying to fix....
> 
> Interesting.  Running the tests on the cr-linux-ews is very new.  It's entirely possible that this is a false positive.
This patch removes a line from test_expectation because it will be fixed by this patch.
I wonder if that case is considered.
I'll land this and see what happens.

[Hajime Morrita]

Committed r84745: <http://trac.webkit.org/changeset/84745>

[Adam Barth]

As predicted, the test is now failing on the bots:

http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit%20Linux

[Hajime Morrita]

> http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit%20Linux
You are right. I'll skip it again...

[Hajime Morrita]

> You are right. I'll skip it again...
Not skip, just mark as fail.