Needed for these tests: fast/dom/Element/scale-page-bounding-client-rect.html fast/dom/Element/scale-page-client-rects.html fast/dom/Range/scale-page-bounding-client-rect.html fast/dom/Range/scale-page-client-rects.html fast/repaint/scale-page-shrink.html fast/transforms/selection-bounds-in-transformed-view.html
Created attachment 90504 [details] proposed patch
Comment on attachment 90504 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=90504&action=review Awesome! Thanks for implementing this. > Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:787 > +void DumpRenderTreeSupportGtk::scale(WebKitWebView* webView, float scaleFactor, float x, float y) Please name this method scalePageBy to match the name of the callback in DRT. This will make it more obvious why this is needed above the scaling options we already have in our API.
Committed r84507: <http://trac.webkit.org/changeset/84507>
http://trac.webkit.org/changeset/84507 might have broken GTK Linux 32-bit Release
Committed r84540: <http://trac.webkit.org/changeset/84540>
Created attachment 90694 [details] updated patch
Sorry for the trouble :( The first patch didn't reset the view scale to 1 in DRT's resetDefaultsToConsistentValues... hence the massive breakage.
Created attachment 90695 [details] updated patch Renamed scale to scalePageBy
Comment on attachment 90695 [details] updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=90695&action=review Thanks for the fix! > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:443 > + DumpRenderTreeSupportGtk::scalePageBy(webView, 1.0f, 0.0f, 0.0f); The WebKit style guidelines say these numbers should just be 1, 0, and 0 respectively (no .0f). Please fix before landing!
(In reply to comment #9) > (From update of attachment 90695 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90695&action=review > > Thanks for the fix! > > > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:443 > > + DumpRenderTreeSupportGtk::scalePageBy(webView, 1.0f, 0.0f, 0.0f); > > The WebKit style guidelines say these numbers should just be 1, 0, and 0 respectively (no .0f). Please fix before landing! Seems we need a bug against check-webkit-style.
file bug 59203 about check-webkit-style.
Committed r84637: <http://trac.webkit.org/changeset/84637>
*** Bug 61396 has been marked as a duplicate of this bug. ***