RESOLVED FIXED Bug 59082
[GTK] DRT: implement eventSender.scalePageBy 
https://bugs.webkit.org/show_bug.cgi?id=59082
Summary [GTK] DRT: implement eventSender.scalePageBy
Philippe Normand
Reported 2011-04-21 01:05:14 PDT
Needed for these tests: fast/dom/Element/scale-page-bounding-client-rect.html fast/dom/Element/scale-page-client-rects.html fast/dom/Range/scale-page-bounding-client-rect.html fast/dom/Range/scale-page-client-rects.html fast/repaint/scale-page-shrink.html fast/transforms/selection-bounds-in-transformed-view.html
Attachments
proposed patch (10.99 KB, patch)
2011-04-21 02:24 PDT, Philippe Normand 		mrobinson: review+
DetailsFormatted DiffDiff
updated patch (11.52 KB, patch)
2011-04-22 05:28 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
updated patch (11.55 KB, patch)
2011-04-22 05:35 PDT, Philippe Normand 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-04-21 02:24:04 PDT
Created attachment 90504 [details] proposed patch
Martin Robinson
Comment 2 2011-04-21 08:59:57 PDT
Comment on attachment 90504 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=90504&action=review Awesome! Thanks for implementing this. > Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:787 > +void DumpRenderTreeSupportGtk::scale(WebKitWebView* webView, float scaleFactor, float x, float y) Please name this method scalePageBy to match the name of the callback in DRT. This will make it more obvious why this is needed above the scaling options we already have in our API.
Philippe Normand
Comment 3 2011-04-21 09:25:06 PDT
Committed r84507: <http://trac.webkit.org/changeset/84507>
WebKit Review Bot
Comment 4 2011-04-21 10:46:12 PDT
http://trac.webkit.org/changeset/84507 might have broken GTK Linux 32-bit Release
Martin Robinson
Comment 5 2011-04-21 12:36:27 PDT
Committed r84540: <http://trac.webkit.org/changeset/84540>
Philippe Normand
Comment 6 2011-04-22 05:28:22 PDT
Created attachment 90694 [details] updated patch
Philippe Normand
Comment 7 2011-04-22 05:29:54 PDT
Sorry for the trouble :( The first patch didn't reset the view scale to 1 in DRT's resetDefaultsToConsistentValues... hence the massive breakage.
Philippe Normand
Comment 8 2011-04-22 05:35:34 PDT
Created attachment 90695 [details] updated patch Renamed scale to scalePageBy
Martin Robinson
Comment 9 2011-04-22 06:52:11 PDT
Comment on attachment 90695 [details] updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=90695&action=review Thanks for the fix! > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:443 > + DumpRenderTreeSupportGtk::scalePageBy(webView, 1.0f, 0.0f, 0.0f); The WebKit style guidelines say these numbers should just be 1, 0, and 0 respectively (no .0f). Please fix before landing!
Eric Seidel (no email)
Comment 10 2011-04-22 09:13:12 PDT
(In reply to comment #9) > (From update of attachment 90695 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90695&action=review > > Thanks for the fix! > > > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:443 > > + DumpRenderTreeSupportGtk::scalePageBy(webView, 1.0f, 0.0f, 0.0f); > > The WebKit style guidelines say these numbers should just be 1, 0, and 0 respectively (no .0f). Please fix before landing! Seems we need a bug against check-webkit-style.
Eric Seidel (no email)
Comment 11 2011-04-22 09:14:46 PDT
file bug 59203 about check-webkit-style.
Philippe Normand
Comment 12 2011-04-22 09:47:39 PDT
Committed r84637: <http://trac.webkit.org/changeset/84637>
Martin Robinson
Comment 13 2011-06-15 09:08:08 PDT
*** Bug 61396 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.