Bug 58977 - [Qt] REGRESSION(r84296): platform/qt/fast/history/back-to-unreachable-url-then-forward.html fails
Summary: [Qt] REGRESSION(r84296): platform/qt/fast/history/back-to-unreachable-url-the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Major
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 57898
  Show dependency tree / graph
 
Reported: 2011-04-20 03:49 PDT by Csaba Osztrogonác
Modified: 2011-04-22 15:01 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-04-20 03:49:53 PDT 
http://trac.webkit.org/changeset/84296 made platform/qt/fast/history/back-to-unreachable-url-then-forward.html fail.

--- /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/platform/qt/fast/history/back-to-unreachable-url-then-forward-expected.txt	2011-04-20 03:17:30.515293567 -0700
+++ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/platform/qt/fast/history/back-to-unreachable-url-then-forward-actual.txt	2011-04-20 03:17:30.515293567 -0700
@@ -1 +1 @@
-SUCCESS
+

I cc-ed Antonio and Yong, the reviewer and the author of this test case. (https://bugs.webkit.org/show_bug.cgi?id=55969)
Comment 1 Csaba Osztrogonác 2011-04-20 04:05:21 PDT 
I added it to the Skipped list: http://trac.webkit.org/changeset/84355
Comment 2 Yong Li 2011-04-20 07:40:35 PDT 
(In reply to comment #1)
> I added it to the Skipped list: http://trac.webkit.org/changeset/84355

Have you seen anything wrong with the test case?

I think it is more like a bug in the patch of 57898: probably FrameView::resetScrollbarsAndClearContentsSize() is never called when going to an unreachable URL.
Comment 3 Beth Dakin 2011-04-21 16:16:40 PDT 
I am looking into this.
Comment 4 Beth Dakin 2011-04-21 23:30:49 PDT 
(In reply to comment #3)
> I am looking into this.

Okay, hopefully revision 84604 fixed this.
Comment 5 Antonio Gomes 2011-04-22 14:28:17 PDT 
Ossy, could we try unskiping it?
Comment 6 Antonio Gomes 2011-04-22 14:28:56 PDT 
Thanks beth!
Comment 7 Beth Dakin 2011-04-22 14:29:37 PDT 
(In reply to comment #6)
> Thanks beth!

No problem! I hope it works.
Comment 8 Csaba Osztrogonác 2011-04-22 14:58:49 PDT 
(In reply to comment #5)
> Ossy, could we try unskiping it?

Sure. I tested, and unspipped: http://trac.webkit.org/changeset/84686.

Beth, thanks for fixing it.
Comment 9 Beth Dakin 2011-04-22 15:01:28 PDT 
(In reply to comment #8)
> (In reply to comment #5)
> > Ossy, could we try unskiping it?
> 
> Sure. I tested, and unspipped: http://trac.webkit.org/changeset/84686.
> 
> Beth, thanks for fixing it.

Yay!