Bug 58977 – [Qt] REGRESSION(r84296): platform/qt/fast/history/back-to-unreachable-url-then-forward.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

http://trac.webkit.org/changeset/84296 made platform/qt/fast/history/back-to-unreachable-url-then-forward.html fail.

--- /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/platform/qt/fast/history/back-to-unreachable-url-then-forward-expected.txt	2011-04-20 03:17:30.515293567 -0700
+++ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/platform/qt/fast/history/back-to-unreachable-url-then-forward-actual.txt	2011-04-20 03:17:30.515293567 -0700
@@ -1 +1 @@
-SUCCESS
+

I cc-ed Antonio and Yong, the reviewer and the author of this test case. (https://bugs.webkit.org/show_bug.cgi?id=55969)

[Csaba Osztrogonác]

I added it to the Skipped list: http://trac.webkit.org/changeset/84355

[Yong Li]

(In reply to comment #1)
> I added it to the Skipped list: http://trac.webkit.org/changeset/84355

Have you seen anything wrong with the test case?

I think it is more like a bug in the patch of 57898: probably FrameView::resetScrollbarsAndClearContentsSize() is never called when going to an unreachable URL.

[Beth Dakin]

I am looking into this.

[Beth Dakin]

(In reply to comment #3)
> I am looking into this.

Okay, hopefully revision 84604 fixed this.

[Antonio Gomes]

Ossy, could we try unskiping it?

[Antonio Gomes]

Thanks beth!

[Beth Dakin]

(In reply to comment #6)
> Thanks beth!

No problem! I hope it works.

[Csaba Osztrogonác]

(In reply to comment #5)
> Ossy, could we try unskiping it?

Sure. I tested, and unspipped: http://trac.webkit.org/changeset/84686.

Beth, thanks for fixing it.

[Beth Dakin]

(In reply to comment #8)
> (In reply to comment #5)
> > Ossy, could we try unskiping it?
> 
> Sure. I tested, and unspipped: http://trac.webkit.org/changeset/84686.
> 
> Beth, thanks for fixing it.

Yay!