WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
55969
Document state is not saved when going backward to unreachable URL
https://bugs.webkit.org/show_bug.cgi?id=55969
Summary
Document state is not saved when going backward to unreachable URL
Yong Li
Reported
2011-03-08 14:32:50 PST
How to reproduce the issue: 1) load file:///non-existent and expect an error page. 2) load a valid scrollable page without any input box (for example www.cnn.com but not google.ca) 3) scroll to some point (and/or zoom the page) 4) go backward to file://non-existent 5) go forward. You will see the scroll position is not restored. Redo the previous test with file:///non-existent replaced by a valid URl, and you can see scroll position is restored correctly.
Attachments
proposed patch
(1.62 KB, patch)
2011-03-08 14:44 PST
,
Yong Li
tonikitoo
: review-
Details
Formatted Diff
Diff
With test case
(4.91 KB, patch)
2011-03-31 15:15 PDT
,
Yong Li
no flags
Details
Formatted Diff
Diff
fix the commit log
(5.11 KB, patch)
2011-04-01 10:28 PDT
,
Yong Li
tonikitoo
: review+
tonikitoo
: commit-queue-
Details
Formatted Diff
Diff
Moving the test case to LayoutTests/platform/qt
(5.32 KB, patch)
2011-04-04 08:09 PDT
,
Yong Li
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Yong Li
Comment 1
2011-03-08 14:44:13 PST
Created
attachment 85091
[details]
proposed patch
Yong Li
Comment 2
2011-03-08 14:50:54 PST
Safari has this problem but chrome doesn't
Antonio Gomes
Comment 3
2011-03-09 22:48:10 PST
Comment on
attachment 85091
[details]
proposed patch Yong, could you please add a layout test for it. Should not be hard, see LayoutTests/fast/history/back-forward-reset-after-error-handling.html for reference.
Yong Li
Comment 4
2011-03-31 15:15:41 PDT
Created
attachment 87796
[details]
With test case Finally got a test case. It needs the DRT to support error page
Antonio Gomes
Comment 5
2011-04-01 07:09:29 PDT
Comment on
attachment 87796
[details]
With test case View in context:
https://bugs.webkit.org/attachment.cgi?id=87796&action=review
> Source/WebCore/ChangeLog:10 > + It can be manually tested with any page. I haven't > + been able to write an auto test with layoutTestController.
No? :)
Yong Li
Comment 6
2011-04-01 10:28:36 PDT
Created
attachment 87879
[details]
fix the commit log
Antonio Gomes
Comment 7
2011-04-01 12:55:37 PDT
Comment on
attachment 87879
[details]
fix the commit log r+, but before landing, as discussed with Yong, we should move both test and expected result files to LayoutTest/platform/qt/fast/history before landing, since Qt is the only DRT that support errorPageHandling at the moment.
Yong Li
Comment 8
2011-04-04 08:09:47 PDT
Created
attachment 88062
[details]
Moving the test case to LayoutTests/platform/qt
WebKit Commit Bot
Comment 9
2011-04-04 10:06:17 PDT
Comment on
attachment 88062
[details]
Moving the test case to LayoutTests/platform/qt Clearing flags on attachment: 88062 Committed
r82843
: <
http://trac.webkit.org/changeset/82843
>
WebKit Commit Bot
Comment 10
2011-04-04 10:06:21 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug