Bug 58726 – ASSERT failure when svg <use> element changes href

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Leo Yang]

ASSERT failure in SVGUseElement.cpp:509 when load the following document.

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">

<g>
    <use id="use" xlink:href="#rect" />
</g>

<defs>
    <rect id="rect" x="0" y="0" width="100" height="60" />
</defs>

<script>
    if (window.layoutTestController)
        layoutTestController.waitUntilDone();

    function runTest()
    {   
        document.getElementById("use").setAttribute("xlink:href", "");
        if (window.layoutTestController)
            layoutTestController.notifyDone();
    }   

    window.setTimeout("runTest()", 0); 
</script>

</svg>

[Leo Yang]

Created attachment 89921 [details]
Patch

[Nikolas Zimmermann]

Comment on attachment 89921 [details]
Patch

Good catch!

[WebKit Commit Bot]

Comment on attachment 89921 [details]
Patch

Rejecting attachment 89921 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 1

Last 500 characters of output:
autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://queues.webkit.org/results/8459397

[Leo Yang]

Comment on attachment 89921 [details]
Patch

Let the cq try again

[Eric Seidel (no email)]

Sorry about that. :(

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 89921 [details]:

http/tests/xmlhttprequest/basic-auth-nopassword.html bug 53170
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 89921 [details]
Patch

Clearing flags on attachment: 89921

Committed r84090: <http://trac.webkit.org/changeset/84090>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.