Bug 58704 - Decide on node type for ShadowRoot
Summary: Decide on node type for ShadowRoot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Roland Steiner
URL:
Keywords:
Depends on:
Blocks: 48698 54179
  Show dependency tree / graph
 
Reported: 2011-04-15 15:39 PDT by Roland Steiner
Modified: 2011-04-21 11:24 PDT (History)
7 users (show)

See Also:

Attachments
Patch (23.18 KB, patch)
2011-04-20 17:32 PDT, Roland Steiner 		no flags Details | Formatted Diff | Diff
patch, cleanup, added WebKit parts (24.74 KB, patch)
2011-04-21 10:26 PDT, Roland Steiner 		dglazkov: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2011-04-15 15:39:41 PDT 
ShadowRoot currently returns a placeholder DOCUMENT_FRAGMENT_NODE as node type.

We need to decide whether to keep that, or whether to introduce a new node type.
Comment 1 Dimitri Glazkov (Google) 2011-04-19 09:23:19 PDT 
Let's just call it SHADOW_ROOT.
Comment 2 Roland Steiner 2011-04-19 13:12:56 PDT 
That sounds straightforward. As it so happens, I already have a stashed CL with that exact name... :)

Just need to re-land the ShadowRoot patch first.
Comment 3 Dominic Cooney 2011-04-20 11:29:47 PDT 
Would we expose this to JavaScript as a constant on Node? Node.SHADOW_ROOT_NODE?
Comment 4 Roland Steiner 2011-04-20 14:43:05 PDT 
Good question - I intended not to, to minimize user-visible changes, but perhaps we have to (for inspector, for example)?
Comment 5 Dimitri Glazkov (Google) 2011-04-20 15:26:11 PDT 
At this point, let's not worry about JS constants.
Comment 6 Roland Steiner 2011-04-20 17:32:10 PDT 
Created attachment 90456 [details]
Patch
Comment 7 Dimitri Glazkov (Google) 2011-04-20 21:01:48 PDT 
Comment on attachment 90456 [details]
Patch

nifty.
Comment 8 Roland Steiner 2011-04-21 10:26:07 PDT 
Created attachment 90552 [details]
patch, cleanup, added WebKit parts

New patch, including cleanup after Dominics patch remarks, and added bits for Source/WebKit.
Comment 9 Dimitri Glazkov (Google) 2011-04-21 10:27:44 PDT 
Comment on attachment 90552 [details]
patch, cleanup, added WebKit parts

even niftier.
Comment 10 Roland Steiner 2011-04-21 10:44:27 PDT 
Committed r84520: <http://trac.webkit.org/changeset/84520>
Comment 11 WebKit Review Bot 2011-04-21 11:24:41 PDT 
http://trac.webkit.org/changeset/84520 might have broken Qt Linux ARMv7 Release and Qt Windows 32-bit Debug