Bug 58590 – media/video-controls-transformed.html is broken

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Ami Fischman]

media/video-controls-transformed.html is ignored by all ports, and is broken because it hard-coded click locations for a control that varies by port (and has moved within ports, too).

[Ami Fischman]

Created attachment 89677 [details]
Stop hard-coding pixel values.

[David Levin]

Comment on attachment 89677 [details]
Stop hard-coding pixel values.

View in context: https://bugs.webkit.org/attachment.cgi?id=89677&action=review

> LayoutTests/media/video-controls-transformed.html:22
> +                // This hard-codes the contruction order of the media controls,

typo: contruction

> LayoutTests/media/video-controls-transformed.html:23
> +                // but is currently the only way to do it.  http://webk.it/58584

typo: "but is" (Perhaps "but that is")
typo: http://webk.it/58584

[Ami Fischman]

(In reply to comment #2)
> (From update of attachment 89677 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89677&action=review
> 
> > LayoutTests/media/video-controls-transformed.html:22
> > +                // This hard-codes the contruction order of the media controls,
> 
> typo: contruction

Done.

> > LayoutTests/media/video-controls-transformed.html:23
> > +                // but is currently the only way to do it.  http://webk.it/58584
> 
> typo: "but is" (Perhaps "but that is")

I think the previous version was grammatically correct, but attempted a clarification.

> typo: http://webk.it/58584

What's the typo?

[Ami Fischman]

Created attachment 91050 [details]
CR1 responses.

[David Levin]

Comment on attachment 91050 [details]
CR1 responses.

View in context: https://bugs.webkit.org/attachment.cgi?id=91050&action=review

> LayoutTests/media/video-controls-transformed.html:24
> +                // way to do it.  http://webk.it/58584 is tracking fixing that.

Cute: webk.it but it doesn't feel like it belongs in code like this when it really isn't controlled by the project. (It seems odd to me at least.)

[Ami Fischman]

Created attachment 91133 [details]
CR2 responses.

[WebKit Commit Bot]

Comment on attachment 91133 [details]
CR2 responses.

Clearing flags on attachment: 91133

Committed r85015: <http://trac.webkit.org/changeset/85015>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Philippe Normand]

*** Bug 50706 has been marked as a duplicate of this bug. ***