Bug 50706 - [GTK] media/video-controls-transformed.html fails
Summary: [GTK] media/video-controls-transformed.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-08 12:02 PST by Philippe Normand
Modified: 2011-05-03 02:31 PDT (History)
3 users (show)

See Also:


Attachments
proposed patch (2.83 KB, patch)
2010-12-08 12:05 PST, Philippe Normand
eric.carlson: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-12-08 12:02:15 PST
A CSS rotation is applied to a video element and the event sender clicks at a fixed position supposed to be the play button. But this depends on the controls. So we should instead calculate the position depending on the video dimensions and rotation angle.
Comment 1 Philippe Normand 2010-12-08 12:05:35 PST
Created attachment 75942 [details]
proposed patch
Comment 2 Philippe Normand 2010-12-08 12:06:34 PST
Comment on attachment 75942 [details]
proposed patch

Would something like this make sense Eric? If so can you please check the test still passes on mac?
Comment 3 Eric Carlson 2010-12-24 12:06:15 PST
Comment on attachment 75942 [details]
proposed patch

This doesn't work on the Mac. The mouse is clicked at {2,182}, but the center of the play/pause button is at about {194,24}.

I think the only way to make this work for all ports will be for DRT to get the location of the control elements from the shadow tree at runtime.
Comment 4 Philippe Normand 2011-05-03 02:13:03 PDT
r85015 fixed this test like Eric suggested. I'll unskip it on GTK since it passes fine now!

*** This bug has been marked as a duplicate of bug 58590 ***
Comment 5 Philippe Normand 2011-05-03 02:31:47 PDT
Committed r85594: <http://trac.webkit.org/changeset/85594>