WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
58296
new-run-webkit-tests: configure logging in child processes properly
https://bugs.webkit.org/show_bug.cgi?id=58296
Summary
new-run-webkit-tests: configure logging in child processes properly
Dirk Pranke
Reported
2011-04-11 20:04:07 PDT
new-run-webkit-tests: configure logging in child processes properly
Attachments
Patch
(3.89 KB, patch)
2011-04-11 20:05 PDT
,
Dirk Pranke
ojan
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2011-04-11 20:05:03 PDT
Created
attachment 89148
[details]
Patch
Eric Seidel (no email)
Comment 2
2011-04-12 10:59:24 PDT
Comment on
attachment 89148
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=89148&action=review
I don't really understand what this chagne does.
> Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:322 > + # FIXME: this won't work if the calling process is logging
nit: "This" since it starts the sentence.
Dirk Pranke
Comment 3
2011-04-12 11:26:31 PDT
(In reply to
comment #2
)
> (From update of
attachment 89148
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=89148&action=review
> > I don't really understand what this chagne does. >
This change is modifying the code that runs in the child processes when NRWT is running in multi-process mode. Specifically, it is modifying the logging configuration to match the configuration in the master/parent process. This wasn't needed on Unix since the configuration is cloned through fork(), but the windows code doesn't fork(), so we have to explicitly reconfigure it.
> > Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:322 > > + # FIXME: this won't work if the calling process is logging > > nit: "This" since it starts the sentence.
Will fix when I land or in the next patch if other changes are needed.
Dirk Pranke
Comment 4
2011-04-13 14:01:18 PDT
Committed
r83760
: <
http://trac.webkit.org/changeset/83760
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug