Bug 55163 – new-run-webkit-tests: enable multiple processes by default on Chromium Win

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

nrwt: enable multiple processes by default on windows

[Dirk Pranke]

Created attachment 83686 [details]
Patch

[Dirk Pranke]

Committed r79628: <http://trac.webkit.org/changeset/79628>

[Dirk Pranke]

Okay, turns out processes don't work so well just yet.

Two issues I saw:

1) output from the child python processes wasn't getting piped back into the parent processes. I think I had noticed this before and forgotten about it, but this is not a great thing to have going on in --verbose mode. Because of the way windows multiprocessing works, the processes don't share file descriptors, and so I don't get this for free. I think the thing to do is to send the log strings over the message queue. In general we only log a couple of messages per test in the worker, so it shouldn't do more than double the message load.

At the same time, on the dbg 2 bot, everything was totally broken: see http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20%28dbg%29%282%29/builds/1265/steps/webkit_gpu_tests/logs/stdio . So it's hard to conclude much from that.

[Dirk Pranke]

reverted in http://trac.webkit.org/changeset/79641

[Dirk Pranke]

I don't think it should block bug 34984 and I plan to clear the blocking flag on Mon 4/11. If you disagree, now would be a good time to speak up :).

[Dirk Pranke]

okay, given the fix to the web server on windows and the logging fix in 58296, everything seems to work for me, so it's time to try again ...

[Dirk Pranke]

clearing blocking flag.

[Dirk Pranke]

Committed r83764: <http://trac.webkit.org/changeset/83764>