Bug 58243 - fix crc computation on 64 bit machines
Summary: fix crc computation on 64 bit machines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 58173
  Show dependency tree / graph
 
Reported: 2011-04-11 09:51 PDT by Tony Chang
Modified: 2011-04-11 16:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.75 KB, patch)
2011-04-11 09:53 PDT, Tony Chang 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-04-11 09:51:53 PDT 
fix crc computation on 64 bit machines
Comment 1 Tony Chang 2011-04-11 09:53:43 PDT 
Created attachment 89019 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-04-11 11:25:35 PDT 
Comment on attachment 89019 [details]
Patch

I like this change.  No way to test it?
Comment 3 Tony Chang 2011-04-11 11:36:37 PDT 
Committed r83461: <http://trac.webkit.org/changeset/83461>
Comment 4 Tony Chang 2011-04-11 11:37:40 PDT 
(In reply to comment #2)
> (From update of attachment 89019 [details])
> No way to test it?

AFAIK, there's no way to write tests for DRT code.
Comment 5 Alexey Proskuryakov 2011-04-11 15:05:43 PDT 
Why not uint32_t? Unlike unsigned, it's actually really always 32 bit.
Comment 6 Tony Chang 2011-04-11 16:24:59 PDT 
(In reply to comment #5)
> Why not uint32_t? Unlike unsigned, it's actually really always 32 bit.

It looks like stdint.h isn't included with MSVC, but there's a copy in Source/JavaScriptCore/os-win32 that has uint32_t defined.  It seems like I could either change the include path on win and win-cairo or just #if COMPILER(MSVC) the typedef.  Does one of these sound like the preferred way to you, Alexey?