Bug 58173 – [Qt] embed checksums in PNGs written by Qt-DRT

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

[qt] embed checksums in PNGs written by DRT QT

[Tony Chang]

Created attachment 88894 [details]
Patch

[Tony Chang]

Created attachment 88895 [details]
fix license

[Eric Seidel (no email)]

Comment on attachment 88895 [details]
fix license

View in context: https://bugs.webkit.org/attachment.cgi?id=88895&action=review

> Tools/DumpRenderTree/CyclicRedundancyCheck.cpp:36
> +static void makeCrcTable(unsigned int crcTable[256])

Why not just "unsigned"?  I don't think the "int" adds anything here.

> Tools/DumpRenderTree/qt/DumpRenderTree.pro:32
> +    ../CyclicRedundancyCheck.h \

Does the .pro normally use ../ relative paths?

[Csaba Osztrogonác]

Comment on attachment 88895 [details]
fix license

View in context: https://bugs.webkit.org/attachment.cgi?id=88895&action=review

Unfortunately DRT crashes sometimes with this patch.
r- now due to crashes. I will check it, and try to help fixing it.

>> Tools/DumpRenderTree/qt/DumpRenderTree.pro:32
>> +    ../CyclicRedundancyCheck.h \
> 
> Does the .pro normally use ../ relative paths?

It works, but we usually add the directory to INCLUDEPATH instead of using relative header paths.

[Csaba Osztrogonác]

*** Bug 58021 has been marked as a duplicate of this bug. ***

[Csaba Osztrogonác]

Created attachment 88995 [details]
crash log

I got this crash log with the following command:
$ WebKitBuild/Release/bin/DumpRenderTree LayoutTests/svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg

I can't reproduce this crash in debug mode and/or without your patch.

If we don't pass --pixel-tests, your code doesn't run.
I don't understand what and why cause this strange crash.

[Tony Chang]

Splitting the 64bit fix into a separate bug while I look into the 64bit test crash.

[Tony Chang]

(In reply to comment #6)
> Created an attachment (id=88995) [details]
> crash log
> 
> I got this crash log with the following command:
> $ WebKitBuild/Release/bin/DumpRenderTree LayoutTests/svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg
> 
> I can't reproduce this crash in debug mode and/or without your patch.
> 
> If we don't pass --pixel-tests, your code doesn't run.
> I don't understand what and why cause this strange crash.

I suspect this crash has to do with including FastMalloc.cpp.  When writing this patch, I wasn't sure if it was OK to use wtf types (Vector.h) in QT's DRT.  Up until now, DRT hasn't had any dependencies on wtf except for Assertions.h.

If I can't use wtf, I could either switch to std::vector or duplicate the code (might be simpler since other code probably wants to use WTF::Vector).

[Tony Chang]

Created attachment 89233 [details]
Patch

[Tony Chang]

(In reply to comment #9)
> Created an attachment (id=89233) [details]
> Patch

QT++ for exposing comment writing/reading in the QImage API.

[Andreas Kling]

Comment on attachment 89233 [details]
Patch

Cool! r=me

[Tony Chang]

Committed r83619: <http://trac.webkit.org/changeset/83619>