new-run-webkit-tests: implement support for audio, take two
Created attachment 88940 [details]
Comment on attachment 88940 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=88940&action=review
This is a revised version of the patch(es) landed in bug 58101. Those patches were rolled out because they were crashing new-run-webkit-tests.
The regression turned out to be a result of passing None instead of '' to Port.diff_image(). I have added comments to show the diffs from the previous patch.
> + return True
This chunk is the fix for the crash on diff_image() in chromium ports. This really needs unit tests, but to test it properly requires changing too many other things, so I'll post the unit tests in a separate patch for clarity.
> + if not actual_contents or not expected_contents:
And this is the fix for the webkit-base ports. Again, I will post unit tests in a separate patch for clarity.
unit tests posted in bug 58196.
Committed r83475: <http://trac.webkit.org/changeset/83475>