[WK2] layoutTestController.shadowRoot should return undefined when its argument is not an element

[Dominic Cooney]

For consistency with Mac DRT, and Chromium DRT (and GTK DRT after bug 58119), layoutTestController.shadowRoot should return undefined, not null, when its argument is not an element.

[Dominic Cooney]

Created attachment 88779 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 88779 [details]
Patch

Clearing flags on attachment: 88779

Committed r83270: <http://trac.webkit.org/changeset/83270>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Roben (:aroben)]

fast/dom/HTMLKeygenElement/keygen.html is still failing on WebKit2.

[Adam Roben (:aroben)]

WKBundleNodeHandleCopyElementShadowRoot is returning 0, and LayoutTestController::shadowRoot returns JSValueMakeUndefined in that case.

[Adam Roben (:aroben)]

I mean it returns JSValueMakeNull. But apparently the test wants JSValueMakeUndefined.

[Adam Roben (:aroben)]

It looks like LayoutTestController doesn't have enough information to do the right thing. It's supposed to return undefined if it is passed a non-element node, but it has no way of determining whether a particular node is an element or not.

[Adam Roben (:aroben)]

It's not clear to me that having shadowRoot return different things for non-elements and elements without shadow roots is worthwhile. Why do our tests need that behavior? The tests themselves are quite capable of figuring out what's an element and what isn't.

[Dominic Cooney]

I will work on a patch to make the ports consistent and always return null.

[Dominic Cooney]

Created attachment 88851 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 88851 [details]
Patch

Clearing flags on attachment: 88851

Committed r83333: <http://trac.webkit.org/changeset/83333>

[Dimitri Glazkov (Google)]

All reviewed patches have been landed.  Closing bug.