Bug 58119 - [GTK] layoutTestController.shadowRoot should return undefined if its argument is not an element
Summary: [GTK] layoutTestController.shadowRoot should return undefined if its argument...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-08 00:09 PDT by Dominic Cooney
Modified: 2011-04-08 03:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2011-04-08 00:11 PDT, Dominic Cooney 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Cooney 2011-04-08 00:09:01 PDT 
For consistency with other ports' DRT, layoutTestController.shadowRoot should return undefined, not null, if its argument is not an element.
Comment 1 Dominic Cooney 2011-04-08 00:11:10 PDT 
Created attachment 88776 [details]
Patch
Comment 2 WebKit Commit Bot 2011-04-08 02:24:03 PDT 
The commit-queue encountered the following flaky tests while processing attachment 88776 [details]:

http/tests/inspector/console-xhr-logging.html bug 58125 (authors: caseq@chromium.org, darin@apple.com, loislo@chromium.org, and pfeldman@chromium.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2011-04-08 02:26:18 PDT 
Comment on attachment 88776 [details]
Patch

Clearing flags on attachment: 88776

Committed r83272: <http://trac.webkit.org/changeset/83272>
Comment 4 WebKit Commit Bot 2011-04-08 02:26:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2011-04-08 03:21:00 PDT 
http://trac.webkit.org/changeset/83272 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
http/tests/inspector/resource-har-conversion.html
http/tests/inspector/resource-parameters.html