Bug 58119 - [GTK] layoutTestController.shadowRoot should return undefined if its argument is not an element
: [GTK] layoutTestController.shadowRoot should return undefined if its argument...
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-04-08 00:09 PST by
Modified: 2011-04-08 03:21 PST (History)


Attachments
Patch (1.44 KB, patch)
2011-04-08 00:11 PST, Dominic Cooney
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-04-08 00:09:01 PST
For consistency with other ports' DRT, layoutTestController.shadowRoot should return undefined, not null, if its argument is not an element.
------- Comment #1 From 2011-04-08 00:11:10 PST -------
Created an attachment (id=88776) [details]
Patch
------- Comment #2 From 2011-04-08 02:24:03 PST -------
The commit-queue encountered the following flaky tests while processing attachment 88776 [details]:

http/tests/inspector/console-xhr-logging.html bug 58125 (authors: caseq@chromium.org, darin@apple.com, loislo@chromium.org, and pfeldman@chromium.org)
The commit-queue is continuing to process your patch.
------- Comment #3 From 2011-04-08 02:26:18 PST -------
(From update of attachment 88776 [details])
Clearing flags on attachment: 88776

Committed r83272: <http://trac.webkit.org/changeset/83272>
------- Comment #4 From 2011-04-08 02:26:24 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #5 From 2011-04-08 03:21:00 PST -------
http://trac.webkit.org/changeset/83272 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
http/tests/inspector/resource-har-conversion.html
http/tests/inspector/resource-parameters.html