Bug 58086 - Add stub support for generating Gtk build system from gyp
Summary: Add stub support for generating Gtk build system from gyp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency treegraph
 
Reported: 2011-04-07 14:58 PDT by Eric Seidel (no email)
Modified: 2011-04-07 22:18 PDT (History)
3 users (show)

See Also:


Attachments
Patch (14.27 KB, patch)
2011-04-07 15:00 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch for landing (8.11 KB, patch)
2011-04-07 15:10 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (9.82 KB, patch)
2011-04-07 15:56 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-04-07 14:58:13 PDT
Add stub support for generating Gtk build system from gyp
Comment 1 Eric Seidel (no email) 2011-04-07 15:00:05 PDT
Created attachment 88708 [details]
Patch
Comment 2 Adam Barth 2011-04-07 15:08:31 PDT
Comment on attachment 88708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88708&action=review

> Source/JavaScriptCore/gyp/gtk.gyp:11
> +  'variables': {
> +    'javascriptcore_include_dirs': [
> +      '<(project_dir)',
> +      '<(project_dir)/icu',
> +    ],
> +  },

I'd skip this part.  This isn't correct because Gtk doesn't have header maps.
Comment 3 Eric Seidel (no email) 2011-04-07 15:10:33 PDT
Created attachment 88714 [details]
Patch for landing
Comment 4 Eric Seidel (no email) 2011-04-07 15:56:14 PDT
Created attachment 88720 [details]
Patch
Comment 5 WebKit Review Bot 2011-04-07 15:58:27 PDT
Attachment 88720 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/Change..." exit_code: 1

Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:25:  indentation is not a multiple of four  [pep8/E111] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:27:  indentation is not a multiple of four  [pep8/E111] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:30:  indentation is not a multiple of four  [pep8/E111] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:32:  at least two spaces before inline comment  [pep8/E261] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:37:  indentation is not a multiple of four  [pep8/E111] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:40:  at least two spaces before inline comment  [pep8/E261] [5]
Total errors found: 6 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Eric Seidel (no email) 2011-04-07 16:03:53 PDT
Committed r83225: <http://trac.webkit.org/changeset/83225>