Bug 58086 – Add stub support for generating Gtk build system from gyp

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Add stub support for generating Gtk build system from gyp

[Eric Seidel (no email)]

Created attachment 88708 [details]
Patch

[Adam Barth]

Comment on attachment 88708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88708&action=review

> Source/JavaScriptCore/gyp/gtk.gyp:11
> +  'variables': {
> +    'javascriptcore_include_dirs': [
> +      '<(project_dir)',
> +      '<(project_dir)/icu',
> +    ],
> +  },

I'd skip this part.  This isn't correct because Gtk doesn't have header maps.

[Eric Seidel (no email)]

Created attachment 88714 [details]
Patch for landing

[Eric Seidel (no email)]

Created attachment 88720 [details]
Patch

[WebKit Review Bot]

Attachment 88720 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/Change..." exit_code: 1

Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:25:  indentation is not a multiple of four  [pep8/E111] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:27:  indentation is not a multiple of four  [pep8/E111] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:30:  indentation is not a multiple of four  [pep8/E111] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:32:  at least two spaces before inline comment  [pep8/E261] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:37:  indentation is not a multiple of four  [pep8/E111] [5]
Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:40:  at least two spaces before inline comment  [pep8/E261] [5]
Total errors found: 6 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Committed r83225: <http://trac.webkit.org/changeset/83225>