Bug 57976 - test-webkitpy script fails if not run in the OpenSource directory
Summary: test-webkitpy script fails if not run in the OpenSource directory
Status: RESOLVED DUPLICATE of bug 56888
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-06 13:32 PDT by Lucas Forschler
Modified: 2011-04-06 18:52 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2011-04-06 13:32:18 PDT
If you try to run test-webkitpy from a directory one level up from OpenSource, it fails.  It appears we are hard coding a directory path in the script to find the supporting files.
Comment 1 Eric Seidel (no email) 2011-04-06 18:25:41 PDT
This is what I saw when I tried to run it outside of a webkit checkout:

webkitpy.test.main: INFO     Excluding: webkitpy.common.checkout.scm_unittest (use --all to include)
The current directory (/Projects) is not a WebKit checkout, using /Projects/WebKit
...............................................................................................................................................................................The current directory (/Projects) is not a WebKit checkout, using /Projects/WebKit
.The current directory (/Projects) is not a WebKit checkout, using /Projects/WebKit
.The current directory (/Projects) is not a WebKit checkout, using /Projects/WebKit
.The current directory (/Projects) is not a WebKit checkout, using /Projects/WebKit
.The current directory (/Projects) is not a WebKit checkout, using /Projects/WebKit
.The current directory (/Projects) is not a WebKit checkout, using /Projects/WebKit
..............................root: INFO     this should be logged
............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 974 tests in 18.089s

OK

It passed though...  Could you explain what failure you see?
Comment 2 Eric Seidel (no email) 2011-04-06 18:26:49 PDT
I suspect it may be getting confused by .svn files in the directory you're running it from?  I know dpranke did some hacking to help it find the WebKit checkout when run inside chromium.  That may be related to (or may have broken) your specific case.
Comment 3 Dirk Pranke 2011-04-06 18:38:43 PDT
(In reply to comment #2)
> I suspect it may be getting confused by .svn files in the directory you're running it from?  I know dpranke did some hacking to help it find the WebKit checkout when run inside chromium.  That may be related to (or may have broken) your specific case.

I think Eric is correct about the diagnosis but confused about the blame. I didn't do anything to make this worse AFAIK, and it's been broken for quite a while.

See bug 56888 which is likely the same problem in a different direction.
Comment 4 Lucas Forschler 2011-04-06 18:52:33 PDT
bug 56888 looks to be culprit, marking as dupe.

*** This bug has been marked as a duplicate of bug 56888 ***