RESOLVED WONTFIX 56888
webkit-patch doesn't work right in the default gclient-based chromium checkout of webkit 
https://bugs.webkit.org/show_bug.cgi?id=56888
Summary webkit-patch doesn't work right in the default gclient-based chromium checkou...
Dirk Pranke
Reported 2011-03-22 19:07:23 PDT
Because Chromium attempts to be "smart" when it checks out webkit using gclient, we only check out sub directories of webkit we need to compile rather than the whole tree. Unfortunately, this has the effect of creating multiple SVN repositories, and scm.checkout_root gets pointed at things other than the top of the tree (e.g., WebKit/Source, WebKit/Tools, etc. rather than just WebKit/). This causes most of the Executive calls to try and spawn things in the wrong location and you get weird errors as a result. We should probably be using a method that hangs off of a Port object (like NRWT does) or at least something hanging off of a Checkout object rather than using scm.default_scm() or scm.find_checkout_root().
Attachments
Add attachment proposed patch, testcase, etc.
Lucas Forschler
Comment 1 2011-04-06 18:52:33 PDT
*** Bug 57976 has been marked as a duplicate of this bug. ***
Eric Seidel (no email)
Comment 2 2011-10-12 14:31:59 PDT
Is this still true?
Dirk Pranke
Comment 3 2011-10-12 14:47:52 PDT
as far as I know, yes.
Adam Barth
Comment 4 2011-10-12 15:06:01 PDT
I'm tempted to wontfix this bug. We can print out a helpful error message, but we shouldn't be in the business of supporting this configuration.
Dirk Pranke
Comment 5 2011-10-12 15:12:35 PDT
note that the "NewGit" workflow in chromium currently forces a checkout of the whole tree, so the partial-checkout configuration may be on its last legs anway (see http://crbug.com/100100) - or they might restore the old functionality. Regardless of the above, I think the change I suggest in the description (to make scm more robust if there is no .svn/.git at the top of the tree) would be a good one to make.
Stephen Chenney
Comment 6 2013-04-09 16:10:40 PDT
LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.
Note You need to log in before you can comment on or make changes to this bug.