Introduced by https://bugs.webkit.org/show_bug.cgi?id=57760, apply the same style changes that were suggested to the JavaScriptCore version (https://bugs.webkit.org/show_bug.cgi?id=57770) during the review process.
Created attachment 88471 [details] Patch
Comment on attachment 88471 [details] Patch Can you split the 'if' in the implementation into two separate statements to match JSC? Also, is there any advantage in moving this to the cpp to avoid header bloat?
Created attachment 88479 [details] Patch
(In reply to comment #2) > (From update of attachment 88471 [details]) > Can you split the 'if' in the implementation into two separate statements to match JSC? Also, is there any advantage in moving this to the cpp to avoid header bloat? 'if' split. However, in this case only the v8 value is required by the function, and it is also a return value to other functions in the header. We're saving headers already with the exception throwing moved into the cpp file.
Created attachment 88491 [details] Patch
(In reply to comment #5) > Created an attachment (id=88491) [details] > Patch Added a small fix to the WebCore.pro file, moving CallbackFunction.cpp to its corresponding place. This was introduced by https://bugs.webkit.org/show_bug.cgi?id=57770.
Comment on attachment 88491 [details] Patch r=me
Created attachment 88507 [details] Patch
(In reply to comment #8) > Created an attachment (id=88507) [details] > Patch Removed the WebCore.pro fix as it has been already provided by http://trac.webkit.org/changeset/83086.
Comment on attachment 88507 [details] Patch r=me
The commit-queue encountered the following flaky tests while processing attachment 88507 [details]: security/block-test.html bug 55741 (authors: beidson@apple.com, mrowe@apple.com, and sam@webkit.org) The commit-queue is continuing to process your patch.
Comment on attachment 88507 [details] Patch Clearing flags on attachment: 88507 Committed r83115: <http://trac.webkit.org/changeset/83115>
All reviewed patches have been landed. Closing bug.