Bug 57923 – Change EventHandler::updateSelectionForMouseDrag to take a HitTestResult only.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Alice Boxhall]

Change EventHandler::updateSelectionForMouseDrag to take a HitTestResult rather than a Node* and an IntPoint&, as the selection may actually not extend into the Node found by the HitTest.

[Alice Boxhall]

Created attachment 88731 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 88731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88731&action=review

> Source/WebCore/page/EventHandler.cpp:631
> +    Node* targetNode = EventHandler::targetNode(hitTestResult);
>      if (!targetNode)

You should probably rename the local variable so that you don't have to resolve the name of member function like this.

> Source/WebCore/page/EventHandler.cpp:642
> +    IntPoint localPoint = hitTestResult.localPoint();
> +    VisiblePosition targetPosition = targetRenderer->positionForPoint(localPoint);

Why do you need to declare a local variable fot IntPoint?

[Ojan Vafai]

Comment on attachment 88731 [details]
Patch

r- per the above comments. otherwise, this is a nice cleanup.

[Alice Boxhall]

Created attachment 88961 [details]
Patch

[Alice Boxhall]

(In reply to comment #2)
> (From update of attachment 88731 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88731&action=review
> 
> > Source/WebCore/page/EventHandler.cpp:631
> > +    Node* targetNode = EventHandler::targetNode(hitTestResult);
> >      if (!targetNode)
> 
> You should probably rename the local variable so that you don't have to resolve the name of member function like this.

Done.

> > Source/WebCore/page/EventHandler.cpp:642
> > +    IntPoint localPoint = hitTestResult.localPoint();
> > +    VisiblePosition targetPosition = targetRenderer->positionForPoint(localPoint);
> 
> Why do you need to declare a local variable fot IntPoint?

No reason.

[WebKit Commit Bot]

Comment on attachment 88961 [details]
Patch

Clearing flags on attachment: 88961

Committed r83414: <http://trac.webkit.org/changeset/83414>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.