Bug 57716 – REGRESSION: Fullscreen HTML5 Video fails to resize on YouTube when using ClickToFlash

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: Media

When clicking on fullscreen for html5 videos, the video fails to resize.   

*Tested with latest safari, which does not mimic this behavior.

Created attachment 87992 [details]
screenshot of bug

[Alexey Proskuryakov]

Could you please confirm that you are seeing this problem with nightly builds from <http://nightly.webkit.org>, but not with Safari 5.0.4?

Yes, this happens only with the webkit nightly build.  I've isolated this behavior to the the clicktoflash 2.14 extension ( http://hoyois.github.com/safariextensions/clicktoflash/ ).

[Alexey Proskuryakov]

ClickToFlash shouldn't be affecting HTML5 video.

Could you please provide more detailed steps to reproduce, so that we could determine what is happening on the page you're seeing this on?

Created attachment 88144 [details]
Video clip of behavior

Attached is the video of the behavior.  

Website:  youtube.com
HTML5 Video Extension: clicktoflash 2.14

Related Bug?:   https://bugs.webkit.org/show_bug.cgi?id=57795

[Alexey Proskuryakov]

Thanks!

Is it correct that you don't have HTML5 video enabled via <http://www.youtube.com/html5>? Can you see the same problem if you enable it?

I've tried with youtube HTML5 video enabled and disabled, but enabling never works as it always reverts to flash.  Clicktoflash intervenes and forces it to use html5.

One thing to note is that if I go to a site that natively plays html5 video ( apple.com, vimeo ), fullscreen works properly with their own designated html5 video players.  I've also installed and tested youtube5 extension ( http://www.verticalforest.com/youtube5-extension/ ) and the fullscreen works properly.

[Edward Sabol]

I have this problem as well. It started with a recent WebKit Nightly.

[Edward Sabol]

Created attachment 89026 [details]
Screenshot of Vimeo fullscreen behavior

I just wanted to add that the problem occurs with Vimeo videos as well. Clicking the button to go fullscreen turns the background of the web site black, but any graphics on the web page are still visible. The video is centered, but it doesn't enlarge to take up the entire screen. I'm uploading a screenshot of a "fullscreen" Vimeo video being played.

This is with the latest Webkit Nightly (r83424).

[Graham Ballantyne]

Full screen video via the Youtube5 extension stopped working for me in the last few Webkit nightlies (verified on r83750). I'm also seeing the Vimeo problem mentioned by Edward, as well as issues with fullscreen on apple.com (see attachment).

[Graham Ballantyne]

Created attachment 89533 [details]
Screenshot of improper fullscreen video rendering on apple.com

[Graham Ballantyne]

Created attachment 89534 [details]
Screenshot of improper fullscreen video rendering on apple.com

[Jer Noble]

This is probably a duplicate of bug #58291.  Can you verify that it still occurs with a nightly build > r83654?

[Graham Ballantyne]

Vimeo is working on r83831; YouTube via YouTube5 and full-screen on apple.com are still broken (youtube doesn't work at all and apple.com has page artifacts overlaying the video).

Created attachment 89622 [details]
ClicktoFlash fullscreen issue not resolved on r83831

ClicktoFlash 2.2.4 fullscreen issue still persists.

[Rick Baumhauer]

Probably related - when using the YouTube5 Safari extension w/Webkit nightly, the fullscreen control no longer does anything; video stays at normal size. Safari 5.0.5 handles the control properly, expanding video to fullscreen when the control is clicked.

[Rick Baumhauer]

(In reply to comment #17)
> Probably related - when using the YouTube5 Safari extension w/Webkit nightly, the fullscreen control no longer does anything; video stays at normal size. Safari 5.0.5 handles the control properly, expanding video to fullscreen when the control is clicked.

Sorry, had comments turned off via 'Shut Up' extension, didn't realize it until my comment didn't show up. This issue has obviously been noted by others - you can take my report as confirmation that the bug still exists in Webkit Nightly.

Fullscreen html5 video working with r84622 and ClicktoFlash 2.2.5

[Rick Baumhauer]

(In reply to comment #19)
> Fullscreen html5 video working with r84622 and ClicktoFlash 2.2.5

I can confirm that full-screen HTML5 video via the YouTube5 extension is also working correctly in r84622. However, I'm suspicious of r84622's memory use - I noticed it getting sluggish after being open for only a few hours yesterday, and found that, even when I got down to only one open tab, WebKit was using 2GB+ of Real Mem.

Running Safari 5.0.5 today under similar circumstances, and it is currently around 625MB of Real Mem.

[Marc Hoyois]

This has been fixed a long time ago. It should be closed!

[Alexey Proskuryakov]

Thank you for following up on this!