HTML5 Player Has no Fullscreen Mode

[Jer Noble]

3/31/11 11:23 PM Joe Thompson:
Summary:
The HTML 5 video element no longer has a fullscreen button or can be put into fullscreen programatically as "webkitSupportsFullscreen" always returns false.

Steps to Reproduce:
Using WebKit's HTML 5 video element with the default Safari controls or using custom ones (such as on Vimeo) and attempt to put it into fullscreen mode.

Expected Results:
Like on Snow Leopard there is a fullscreen button in the default Safari controls or a custom control that enabled the functionality through JavaScript.

Actual Results:
The default Safari controls that have been updated in Lion have no fullscreen button and JavaScript can no longer programatically put the video element into fullscreen.

Regression:
Fullscreen support (required to ensure HTML 5 video elements can be properly used to replace traditional Flash video players) worked on previous versions of Safari on Snow Leopard.

Notes:
N/A

[Jer Noble]

<rdar://problem/9220025>

[Jer Noble]

Created attachment 88142 [details]
Patch

[Darin Adler]

Comment on attachment 88142 [details]
Patch

Is there an easy way to regression-test this?

[Jer Noble]

(In reply to comment #3)
> (From update of attachment 88142 [details])
> Is there an easy way to regression-test this?

Not really; we'd have to convince DRT to answer "false" to supportsFullscreenForNode(), and "true" to supportsFullscreenForElement(), which would break a lot of existing tests on platforms which don't support the new API.

[Jer Noble]

OTOH, I have a bug which would add support for the new API to WebKitTestRunner, and once that's fixed, this would be easily regression testable.

[Jer Noble]

That WebKitTestRunner bug is: bug #56318.

[WebKit Commit Bot]

Comment on attachment 88142 [details]
Patch

Clearing flags on attachment: 88142

Committed r82991: <http://trac.webkit.org/changeset/82991>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.