Bug 57540 - [GTK] Close connection when web process finishes
Summary: [GTK] Close connection when web process finishes
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on: 57234 57434
Blocks: 57611
  Show dependency treegraph
Reported: 2011-03-31 05:36 PDT by Carlos Garcia Campos
Modified: 2011-04-08 03:29 PDT (History)
0 users

See Also:

Patch (9.83 KB, patch)
2011-03-31 05:49 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-03-31 05:36:57 PDT
Qt port has Connection::setShouldCloseConnectionOnProcessTermination(), we could use it too.
Comment 1 Carlos Garcia Campos 2011-03-31 05:49:17 PDT
Created attachment 87709 [details]

Patch to implement and use WorkQueue::scheduleWorkOnTermination() in GTK platform too.
Comment 2 Martin Robinson 2011-03-31 09:45:07 PDT
Comment on attachment 87709 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=87709&action=review

> Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:90
> +    static gboolean performWorkOnTermination(GPid pid, gint status, EventSource* eventSource)

Here you should omit the name of the GPid parameter and the gint parameter.
Comment 3 Carlos Garcia Campos 2011-04-08 03:28:53 PDT
Committed r83280: <http://trac.webkit.org/changeset/83280>