Bug 57234 - [GTK] Use glib API instead of fork + execl in ProcessLauncherGtk
Summary: [GTK] Use glib API instead of fork + execl in ProcessLauncherGtk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 49791
Blocks: 57540
  Show dependency tree / graph
 
Reported: 2011-03-28 07:57 PDT by Carlos Garcia Campos
Modified: 2011-04-08 03:07 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.43 KB, patch)
2011-03-28 08:02 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Updated patch (3.78 KB, patch)
2011-03-31 03:24 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-03-28 07:57:07 PDT 
The code will be simpler and easier to maintain.
Comment 1 Carlos Garcia Campos 2011-03-28 08:02:08 PDT 
Created attachment 87144 [details]
Patch
Comment 2 Carlos Garcia Campos 2011-03-31 03:24:07 PDT 
Created attachment 87688 [details]
Updated patch

I have updated the patch to call prctl(PR_SET_PDEATHSIG, SIGKILL), (Linux only) to kill the child process when the parent dies like the qt port does.
Comment 3 Martin Robinson 2011-03-31 09:52:49 PDT 
Comment on attachment 87688 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87688&action=review

Great stuff.

> Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:48
> +static void childSetupFunc(gpointer userData)

Perhaps rename this to childSetupFunction or childSetupCallback.
Comment 4 Carlos Garcia Campos 2011-04-08 03:06:47 PDT 
Committed r83277: <http://trac.webkit.org/changeset/83277>