NEW 57412
check-webkit-style lied about bug numbers in my ChangeLogs 
https://bugs.webkit.org/show_bug.cgi?id=57412
Summary check-webkit-style lied about bug numbers in my ChangeLogs
Beth Dakin
Reported 2011-03-29 18:13:45 PDT
See: https://bugs.webkit.org/show_bug.cgi?id=57408
Attachments
Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2011-03-31 20:31:26 PDT
See also: https://bugs.webkit.org/show_bug.cgi?id=57605
David Levin
Comment 2 2011-04-09 20:32:43 PDT
Patrick, could you look into fixing these? We strive to have a very low false positive rate to avoid annoying people with check-webkit-style.
Patrick R. Gansterer
Comment 3 2011-04-10 12:53:08 PDT
(In reply to comment #2) > Patrick, could you look into fixing these? We strive to have a very low false positive rate to avoid annoying people with check-webkit-style. Do you know what the style-queue does with the patch? When I apply the patch to my git woking copy and run "Tools/Scripts/check-webkit-style --diff-files Source/WebCore/ChangeLog", I don't get an error. When I remove the valid bug number from the change in my working copy, it shows an error. So check-webkit-style seams to process the correct change. Unfortunately I'm not able to reproduce this error on my Mac with git repository. An other example of wrong bug number handling is https://bugs.webkit.org/attachment.cgi?id=87693&action=review. The dot at the end of the line seams to confuse check-webkit-style.
Note You need to log in before you can comment on or make changes to this bug.