WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57408
-webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=57408
Summary
-webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
Beth Dakin
Reported
2011-03-29 17:39:28 PDT
Post-SnowLeopard, typing "javascript:alert(window.devicePixelRatio)" into the URL field always returns 1 regardless of the actual device pixel ratio. <
rdar://problem/8665411
>
Attachments
Patch
(15.68 KB, patch)
2011-03-29 18:00 PDT
,
Beth Dakin
no flags
Details
Formatted Diff
Diff
New patch
(15.69 KB, patch)
2011-03-29 18:08 PDT
,
Beth Dakin
no flags
Details
Formatted Diff
Diff
Way cooler patch
(15.53 KB, patch)
2011-03-29 23:29 PDT
,
Beth Dakin
mjs
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Beth Dakin
Comment 1
2011-03-29 18:00:26 PDT
Created
attachment 87445
[details]
Patch The new and the old APIs are implemented on both NSWindow and NSScreen. The call sites that used to have to nil-check NSWindow now just default to NSScreen.
WebKit Review Bot
Comment 2
2011-03-29 18:03:05 PDT
Attachment 87445
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 3 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 3
2011-03-29 18:08:28 PDT
Created
attachment 87447
[details]
New patch
Beth Dakin
Comment 4
2011-03-29 18:08:58 PDT
(In reply to
comment #2
)
>
Attachment 87445
[details]
did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > > Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Total errors found: 3 in 19 files > > > If any of these errors are false positives, please file a bug against check-webkit-style.
You lie style bot. You lie.
WebKit Review Bot
Comment 5
2011-03-29 18:10:05 PDT
Attachment 87447
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 3 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 6
2011-03-29 18:11:47 PDT
(In reply to
comment #5
)
>
Attachment 87447
[details]
did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > > Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Total errors found: 3 in 19 files > > > If any of these errors are false positives, please file a bug against check-webkit-style.
Whatevs. Known liar.
Darin Adler
Comment 7
2011-03-29 18:11:54 PDT
Comment on
attachment 87447
[details]
New patch I’d probably use 72 instead of 72.0 in all those places. If this really is the best practice, then lets land this. I’m kind of surprised, though, because I’d think that we might want a different value if the HI scale factor of the window the view is being displayed in was 2X.
Beth Dakin
Comment 8
2011-03-29 23:29:33 PDT
Created
attachment 87469
[details]
Way cooler patch Thanks for the review Darin, but I take it back! deviceDescription is so two weeks ago. backingScaleFactor is all the rage these days.
WebKit Review Bot
Comment 9
2011-03-29 23:31:59 PDT
Attachment 87469
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 3 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 10
2011-03-29 23:32:43 PDT
(In reply to
comment #9
)
>
Attachment 87469
[details]
did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > > Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Total errors found: 3 in 19 files > > > If any of these errors are false positives, please file a bug against check-webkit-style.
Oh shush, you.
Maciej Stachowiak
Comment 11
2011-03-29 23:35:35 PDT
Comment on
attachment 87469
[details]
Way cooler patch r=me Style checker's lies are probably because the usual style is to put the bugzilla number on a separate line after the bug title. Suggest making that change.
Beth Dakin
Comment 12
2011-03-29 23:44:11 PDT
(In reply to
comment #11
)
> (From update of
attachment 87469
[details]
) > r=me > > Style checker's lies are probably because the usual style is to put the bugzilla number on a separate line after the bug title. Suggest making that change.
Thanks Maciej! I begrudgingly submit my ChangeLog individuality to the style bot overlords. Committed with revision 82398.
Eric Seidel (no email)
Comment 13
2011-04-06 10:46:31 PDT
Comment on
attachment 87447
[details]
New patch Cleared Darin Adler's review+ from obsolete
attachment 87447
[details]
so that this bug does not appear in
http://webkit.org/pending-commit
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug